Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing include to AssociatedVariableCollectionSelector.h #21407

Merged
merged 1 commit into from Nov 23, 2017

Conversation

Teemperor
Copy link
Contributor

We use SelectedOutputCollectionTrait in this header but never
include the associated header that contains the declaration of
SelectedOutputCollectionTrait. This patch adds the missing
include to make this file parsable on its own.

We use SelectedOutputCollectionTrait in this header but never
include the associated header that contains the declaration of
SelectedOutputCollectionTrait. This patch adds the missing
include to make this file parsable on its own.
@Teemperor
Copy link
Contributor Author

Part of the work going on regarding the C++ modules migration of CMSSW (tracked as issue #15248). This PR is not meant to refactor things, but just to make these headers compile.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21407/2114

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Teemperor (Raphael Isemann) for master.

It involves the following packages:

CommonTools/UtilAlgos

@perrotta, @cmsbuild, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 21, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24578/console Started: 2017/11/21 16:45

@cmsbuild
Copy link
Contributor

-1

Tested at: a82ab2e

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
893188d
0707ff5
bbddd85
ed2b195
12605de
3441962
c792deb
8d25c3d
84e2869
54ee550
3468977
eeb8263
32307fd
34b0dcf
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21407/24578/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21407/24578/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21407/24578/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test runtestTqafTopEventProducers had ERRORS
---> test runtestTqafTopEventSelection had ERRORS
---> test runtestTqafExamples had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
893188d
0707ff5
bbddd85
ed2b195
12605de
3441962
c792deb
8d25c3d
84e2869
54ee550
3468977
eeb8263
32307fd
34b0dcf
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21407/24578/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21407/24578/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21407/24578/summary.html

There are some workflows for which there are errors in the baseline:
10824.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3523 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2746803
  • DQMHistoTests: Total failures: 9398
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2737228
  • DQMHistoTests: Total skipped: 177
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.16999999998 KiB( 23 files compared)
  • Checked 111 log files, 8 edm output root files, 27 DQM output files

@perrotta
Copy link
Contributor

please test with #21186
(Trying to see if less merge commits are merged together this time, and we can get rid as such to the differences seen by jenkins, which are not expected due to this PR alone)

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 22, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24623/console Started: 2017/11/22 16:27

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21407/24623/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2833444
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2833265
  • DQMHistoTests: Total skipped: 178
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.37999999989 KiB( 23 files compared)
  • Checked 111 log files, 8 edm output root files, 27 DQM output files

@slava77
Copy link
Contributor

slava77 commented Nov 22, 2017

+1

for #21407 a82ab2e

  • implemented as described; this is technical outside of the scope of getting the header parsable on its own
  • jenkins tests pass

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 63e59e6 into cms-sw:master Nov 23, 2017
@Teemperor Teemperor deleted the AssociatedVar branch December 19, 2017 08:47
@Teemperor Teemperor restored the AssociatedVar branch December 19, 2017 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants