Changing DCS Filter Application in SiStripClusterMonitor #21433

ocolegro · 2017-11-22T14:34:36Z

Hello,

This is work that was requested by Francesco Fiori in order to help with the DQM pipeline. This code is implemented to remove the DCS Filter in the SiStripClusterMonitor from a specific cluster trend plot.

Thank you,
Owen

cmsbuild · 2017-11-22T14:34:57Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-11-22T14:37:41Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21433/2150

cmsbuild · 2017-11-22T14:38:02Z

A new Pull Request was created by @ocolegro for master.

It involves the following packages:

DQM/SiStripMonitorCluster

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @fioriNTU, @hdelanno this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

jfernan2 · 2017-11-22T14:39:28Z

please test

cmsbuild · 2017-11-22T14:39:45Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24611/console Started: 2017/11/22 15:40

ocolegro · 2017-11-22T14:50:55Z

Hi, I was asked to add a description -

This is work that was requested by Francesco Fiori in order to help with the DQM pipeline. This code is implemented to remove the DCS Filter in the SiStripClusterMonitor from a specific cluster trend plot.

Thank you,
Owen

boudoul · 2017-11-22T15:57:28Z

Hi @ocolero there is a box for the description please put it there and very important please also edit the title : 'master' is not explicit at all

cmsbuild · 2017-11-22T17:23:46Z

-1

Tested at: 8f338bb

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
0a3cf1a
029a71a
277f9ce
8da32da
7bd71f2
f069d31
5780cd4
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21433/24611/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21433/24611/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21433/24611/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following worklfows:
10042.0 step5

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step5_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
0a3cf1a
029a71a
277f9ce
8da32da
7bd71f2
f069d31
5780cd4
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21433/24611/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21433/24611/git-merge-result

cmsbuild · 2017-11-22T17:23:48Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

ocolegro · 2017-11-23T14:49:33Z

@dmitrijus I do not believe that our PR is responsible for this error, can we please restart the tests?

Thank you

jfernan2 · 2017-11-23T15:18:42Z

Hi @ocolegro I'm restarting the test but can you please introduce yourself in order to add you to the list of DQM developers?
https://twiki.cern.ch/twiki/bin/viewauth/CMS/DQMContacts
Thanks

jfernan2 · 2017-11-24T15:04:49Z

please test

cmsbuild · 2018-01-14T23:12:39Z

+1
Tested at: 67286f7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21433/25432/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
4f9d580
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21433/25432/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21433/25432/git-merge-result

cmsbuild · 2018-01-14T23:12:42Z

Comparison job queued.

cmsbuild · 2018-01-15T00:37:10Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21433/25432/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21433/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 26
DQMHistoTests: Total histograms compared: 2467599
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2467429
DQMHistoTests: Total skipped: 169
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 1.10999999996 KiB( 22 files compared)
Checked 110 log files, 9 edm output root files, 26 DQM output files

fabiocos · 2018-01-15T10:35:53Z

+1

Dr15Jones · 2018-01-16T13:38:51Z

This change is causing segmentation faults in workflows 140.52, 140.54 and 140.51

Dr15Jones · 2018-01-16T13:40:00Z

please test workflow 140.52, 140.54

cmsbuild · 2018-01-16T13:40:19Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25465/console Started: 2018/01/16 14:40

fabiocos · 2018-01-16T14:26:57Z

@Dr15Jones yes, I have opened an issue #21858

cmsbuild · 2018-01-16T14:55:50Z

-1

Tested at: 67286f7

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21433/25465/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following worklfows:
140.52 step2

runTheMatrix-results/140.52_RunHI2010+RunHI2010+RECOHID10+RECOHIR10D11+HARVESTDHI/step2_RunHI2010+RunHI2010+RECOHID10+RECOHIR10D11+HARVESTDHI.log

140.54 step2

runTheMatrix-results/140.54_RunPA2013+RunPA2013+RECO_PPbData+HARVEST_PPbData/step2_RunPA2013+RunPA2013+RECO_PPbData+HARVEST_PPbData.log

cmsbuild · 2018-01-16T14:55:52Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

ocolegrove added 2 commits November 22, 2017 11:51

Adding in DCS Filter

6d754e4

Adding in DCS Filter

8f338bb

cmsbuild added this to the CMSSW_10_0_X milestone Nov 22, 2017

cmsbuild added code-checks-pending comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels Nov 22, 2017

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 22, 2017

cmsbuild added tests-started and removed tests-pending labels Nov 22, 2017

ocolegro changed the title ~~Master~~ Changing DCS Filter Application in SiStripClusterMonitor Nov 22, 2017

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Nov 22, 2017

cmsbuild added tests-started and removed tests-pending labels Jan 14, 2018

cmsbuild added tests-approved and removed tests-started labels Jan 14, 2018

cmsbuild added comparison-available and removed comparison-pending labels Jan 15, 2018

cmsbuild added orp-approved and removed orp-pending labels Jan 15, 2018

cmsbuild merged commit 1e8a438 into cms-sw:master Jan 15, 2018

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Jan 16, 2018

cmsbuild added tests-started and removed tests-pending labels Jan 16, 2018

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Jan 16, 2018

fabiocos mentioned this pull request Jan 16, 2018

Revert "Changing DCS Filter Application in SiStripClusterMonitor " #21868

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changing DCS Filter Application in SiStripClusterMonitor #21433

Changing DCS Filter Application in SiStripClusterMonitor #21433

ocolegro commented Nov 22, 2017 •

edited

cmsbuild commented Nov 22, 2017

cmsbuild commented Nov 22, 2017

cmsbuild commented Nov 22, 2017

jfernan2 commented Nov 22, 2017

cmsbuild commented Nov 22, 2017 •

edited

ocolegro commented Nov 22, 2017

boudoul commented Nov 22, 2017

cmsbuild commented Nov 22, 2017

cmsbuild commented Nov 22, 2017

ocolegro commented Nov 23, 2017

jfernan2 commented Nov 23, 2017

jfernan2 commented Nov 24, 2017

cmsbuild commented Jan 14, 2018

cmsbuild commented Jan 14, 2018

cmsbuild commented Jan 15, 2018

fabiocos commented Jan 15, 2018

Dr15Jones commented Jan 16, 2018

Dr15Jones commented Jan 16, 2018

cmsbuild commented Jan 16, 2018 •

edited

fabiocos commented Jan 16, 2018

cmsbuild commented Jan 16, 2018

cmsbuild commented Jan 16, 2018

Changing DCS Filter Application in SiStripClusterMonitor #21433

Changing DCS Filter Application in SiStripClusterMonitor #21433

Conversation

ocolegro commented Nov 22, 2017 • edited

cmsbuild commented Nov 22, 2017

cmsbuild commented Nov 22, 2017

cmsbuild commented Nov 22, 2017

jfernan2 commented Nov 22, 2017

cmsbuild commented Nov 22, 2017 • edited

ocolegro commented Nov 22, 2017

boudoul commented Nov 22, 2017

cmsbuild commented Nov 22, 2017

cmsbuild commented Nov 22, 2017

ocolegro commented Nov 23, 2017

jfernan2 commented Nov 23, 2017

jfernan2 commented Nov 24, 2017

cmsbuild commented Jan 14, 2018

cmsbuild commented Jan 14, 2018

cmsbuild commented Jan 15, 2018

fabiocos commented Jan 15, 2018

Dr15Jones commented Jan 16, 2018

Dr15Jones commented Jan 16, 2018

cmsbuild commented Jan 16, 2018 • edited

fabiocos commented Jan 16, 2018

cmsbuild commented Jan 16, 2018

cmsbuild commented Jan 16, 2018

ocolegro commented Nov 22, 2017 •

edited

cmsbuild commented Nov 22, 2017 •

edited

cmsbuild commented Jan 16, 2018 •

edited