EMTF DQM plot updates

[abrinke1]

Improvements to CSC LCT and RPC hit occupancy plots in EMTF Online DQM.

Taken from development code by @chadfreer which includes new quality tests: still in validation phase, to be added in a separate pull request soon-ish.

https://github.com/chadfreer/cmssw/tree/pull_ready_10_0_0_pre1

[cmsbuild]

@abrinke1, CMSSW_10_0_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21459/2190

[abrinke1]

I don't know if anyone will be automatically pinged about this ... but @thomreis and @rekovic at least should be aware of it: and maybe give a +1 at some point?

[cmsbuild]

A new Pull Request was created by @abrinke1 for master.

It involves the following packages:

DQM/Integration
DQM/L1TMonitor

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@makortel, @threus, @kreczko, @thomreis, @batinkov this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24680/console Started: 2017/11/24 20:05

[cmsbuild]

+1
Tested at: f8bd914
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21459/24680/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
85eeced
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21459/24680/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21459/24680/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21459/24680/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2833444
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 4
• DQMHistoTests: Total successes: 2833261
• DQMHistoTests: Total skipped: 178
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 262.08 KiB( 23 files compared)
• Checked 111 log files, 8 edm output root files, 27 DQM output files

[thomreis]

Hi @abrinke1
I do not have the right to give +1s. Anyway, this PR does not need a +1 from L1 since it only concerns DQM code. Please check and use a consistent indentation.

[cmsbuild]

Pull request #21459 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please check and sign again.

[abrinke1]

Hi @thomreis
Thanks for looking at it. I've fixed up the anomalous indents.

To whom it may concern ( @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien, @davidlange6, @slava77, @rekovic ), the L1T DPG (myself and Alex Zabi) would like to officially request that @thomreis get "+1" permissions for L1T code -- even if it's not relevant for this PR -- since he is now our DQM and offline performance coordinator. I'm not sure who sets these permissions, but let us know if there's anything preventing this.

Thanks much,
Andrew

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24692/console Started: 2017/11/27 12:08

[jfernan2]

@abrinke1 Sorry, we cannot put over the shoulders of @thomreis the responsability of signing DQM PRs. Of course we are happy to have his opinion and advice in this and other PRs.
If this PR needs to be implement in Online DQM asap, please use the DQMP5TagCollector[1] and instructions therein. More about this and other matters in[2]

[1] https://twiki.cern.ch/twiki/bin/view/CMS/DQMP5TagCollector
[2] https://twiki.cern.ch/twiki/bin/view/CMS/DQMSequences

[abrinke1]

Hi @jfernan2
Sorry for the confusion - I didn't mean for signing DQM PRs specifically (like this one). I meant L1T software PRs. I just figured that this list / audience might contain someone who knew how to do that.

This particular PR is not urgently needed for use online right now.

Best,
Andrew

[cmsbuild]

+1
Tested at: 35fd4a9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21459/24692/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
a712be6
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21459/24692/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21459/24692/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21459/24692/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2833444
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 4
• DQMHistoTests: Total successes: 2833261
• DQMHistoTests: Total skipped: 178
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 262.35 KiB( 23 files compared)
• Checked 111 log files, 8 edm output root files, 27 DQM output files

[abrinke1]

Are there any comments or objections to this PR? It's a very simple update. Of course I know it's CMS week, as well ...
An ETA on merging this would be nice, since we're planning to build further improvements on top of it.

[dmitrijus]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

+1

[abrinke1]

Thanks!