Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build fail in SimG4Core/CustomPhysics #21473

Merged

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Nov 28, 2017

In this PR #21462 from yesterday double h has been changed to single h after renaming, but not everywhere and the build failed https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc630/CMSSW_10_0_X_2017-11-27-2300/SimG4Core/CustomPhysics
I removed the double h's and now it builds

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@mrodozov
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21473/2207

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 28, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24717/console Started: 2017/11/28 10:19

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov for master.

It involves the following packages:

SimG4Core/CustomPhysics

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor

civanch commented Nov 28, 2017

@mrodozov , thanks, likely files were not added before the commit. How this path test not clear.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit b2cef25 into cms-sw:master Nov 28, 2017
@mrodozov mrodozov deleted the fix-build-fail-simg4core-customphysics branch November 28, 2017 13:03
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21473/24717/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2833444
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2833265
  • DQMHistoTests: Total skipped: 178
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.60000000005 KiB( 23 files compared)
  • Checked 111 log files, 8 edm output root files, 27 DQM output files

@smuzaffar
Copy link
Contributor

@civanch , there is bug in cms-checkdeps due to which it does not recognize the changes made via git mv. That is why the PR test went fine as the missing file was picked up from releases.

@civanch
Copy link
Contributor

civanch commented Nov 28, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants