New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build fail in SimG4Core/CustomPhysics #21473
Fix build fail in SimG4Core/CustomPhysics #21473
Conversation
The code-checks are being triggered in jenkins. |
please test |
+code-checks |
The tests are being triggered in jenkins. |
A new Pull Request was created by @mrodozov for master. It involves the following packages: SimG4Core/CustomPhysics @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@mrodozov , thanks, likely files were not added before the commit. How this path test not clear. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
merge |
Comparison is ready Comparison Summary:
|
@civanch , there is bug in cms-checkdeps due to which it does not recognize the changes made via |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
In this PR #21462 from yesterday double h has been changed to single h after renaming, but not everywhere and the build failed https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc630/CMSSW_10_0_X_2017-11-27-2300/SimG4Core/CustomPhysics
I removed the double h's and now it builds