Use the CMS_THREAD_SAFE macro instead of [[cms::thread_safe]]

[fwyzard]

The Intel Compiler does not seem to support attributes with a namespace:

warning #3924: attribute namespace "cms" is unrecognized

[fwyzard]

@cmsbuild, please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21480/2224

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24730/console Started: 2017/11/28 21:49

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

FWCore/Common
FWCore/Framework
FWCore/MessageLogger
FWCore/MessageService
FWCore/ParameterSet
FWCore/PluginManager
FWCore/Utilities
Utilities/XrdAdaptor

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @felicepantaleo, @ebrondol, @wddgit, @makortel this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24903/console Started: 2017/12/01 14:48

[cmsbuild]

Pull request #21480 was updated. @perrotta, @smuzaffar, @civanch, @Dr15Jones, @lveldere, @arunhep, @ssekmen, @cerminar, @monttj, @cmsbuild, @franzoni, @ghellwig, @mdhildreth, @slava77, @lpernie can you please check and sign again.

[ghellwig]

+1
provided jenkins agrees

[Dr15Jones]

+1

[cmsbuild]

+1
Tested at: 69ed6b8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21480/24903/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
9b38965
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21480/24903/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21480/24903/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21480/24903/summary.html

There are some workflows for which there are errors in the baseline:
10824.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2715851
• DQMHistoTests: Total failures: 21
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2715654
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.17999999998 KiB( 23 files compared)
• Checked 111 log files, 8 edm output root files, 27 DQM output files

[civanch]

+1

[slava77]

+1

for #21480 69ed6b8

• technical update
• jenkins tests pass

[davidlange6]

merge