Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undefined references #21484

Merged
merged 2 commits into from Dec 1, 2017
Merged

Fix undefined references #21484

merged 2 commits into from Dec 1, 2017

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Nov 29, 2017

The latest UBSAN IB revealed a couple more packages failing with missing dependencies.

David Abdurachmanov added 2 commits November 29, 2017 15:01
Add mising dep for HcalGeometry
4b79f41 
Resolves linking errors:

    RecoLocalCaloHGCalRecAlgos/RecHitTools.o:(.data.rel+0x13d8): undefined reference to peinfo for HcalGeometry'
    RecoLocalCaloHGCalRecAlgos/RecHitTools.o:(.data.rel+0x1418): undefined reference to peinfo for HcalGeometry'
    RecoLocalCaloHGCalRecAlgos/RecHitTools.o:(.data.rel+0x1618): undefined reference to peinfo for HcalGeometry'
    RecoLocalCaloHGCalRecAlgos/RecHitTools.o:(.data.rel+0x1658): undefined reference to peinfo for HcalGeometry'

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
Add missing dep for GeometricSearchTracker
4ce9bf0 
Resolves linking errors:

    RecoMuonNavigation/MuonNavigationPrinter.o:(.data.rel+0x1758): undefined reference to peinfo for GeometricSearchTracker'
    RecoMuonNavigation/MuonNavigationPrinter.o:(.data.rel+0x1ed8): undefined reference to peinfo for GeometricSearchTracker'
    RecoMuonNavigation/MuonNavigationPrinter.o:(.data.rel+0x2498): undefined reference to peinfo for GeometricSearchTracker'

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild cmsbuild added this to the CMSSW_10_0_X milestone Nov 29, 2017
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21484/2242

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for master.

It involves the following packages:

RecoLocalCalo/HGCalRecAlgos
RecoMuon/Navigation

@perrotta, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks.
@edjtscott, @vandreev11, @sethzenz, @battibass, @felicepantaleo, @abbiendi, @jhgoh, @lgray, @cseez, @calderona, @echapon, @HuguesBrun, @kpedro88, @rovere, @rociovilar, @bellan, @argiro, @trocino, @bachtis, @pfs this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 29, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24748/console Started: 2017/11/29 17:24

@cmsbuild
Copy link
Contributor

+1
Tested at: 4ce9bf0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21484/24748/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
8eb7f2c
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21484/24748/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21484/24748/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@kpedro88
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21484/24748/summary.html

There are some workflows for which there are errors in the baseline:
10824.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2788080
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2787901
  • DQMHistoTests: Total skipped: 178
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.650000000154 KiB( 23 files compared)
  • Checked 111 log files, 8 edm output root files, 27 DQM output files

@slava77
Copy link
Contributor

slava77 commented Dec 1, 2017

+1

for #21484 4ce9bf0

  • technical buildfile updates
  • jenkins tests pass

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

merge

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 49eee55 into cms-sw:master Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved comparison-available fully-signed orp-approved reconstruction-approved tests-approved upgrade-approved
Projects
None yet
Milestone
CMSSW_10_0_X
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@davidlt @cmsbuild @perrotta @kpedro88 @slava77 @davidlange6