Migrated HGCFETriggerDigiFwd.h to HGCFETriggerDigiDefs.h #21494

Teemperor · 2017-11-30T10:24:05Z

As discussed in PR #18805, the Fwd.h headers need a definition of
the specific class they wrap. We do the same as we did for this PR
by renaming th efile to *Defs.h and actually including
HGCFETriggerDigi.

Teemperor · 2017-11-30T10:24:08Z

Part of the work going on regarding the C++ modules migration of CMSSW (tracked as issue #15248). This PR is not meant to refactor things, but just to make these headers compile.

cmsbuild · 2017-11-30T10:25:04Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-11-30T10:27:33Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21494/2255

cmsbuild · 2017-11-30T10:28:07Z

A new Pull Request was created by @Teemperor (Raphael Isemann) for master.

It involves the following packages:

DataFormats/L1THGCal
L1Trigger/L1THGCal

@nsmith-, @rekovic, @cmsbuild, @thomreis, @kpedro88 can you please review it and eventually sign? Thanks.
@kreczko, @rovere, @lgray, @Martin-Grunewald, @jbsauvan, @amarini this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

kpedro88 · 2017-11-30T15:33:22Z

DataFormats/L1THGCal/interface/HGCFETriggerDigiDefs.h

@@ -8,6 +8,8 @@

 #include "DataFormats/Common/interface/SortedCollection.h"

+#include "DataFormats/L1THGCal/interface/HGCFETriggerDigi.h"
+
 namespace l1t {
  //fwd decl. of FETriggerDigi


Should this forward declaration be removed?

@Teemperor ping

You're right, updated the PR!

davidlange6 · 2017-11-30T15:42:54Z

please test

cmsbuild · 2017-11-30T15:43:27Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24896/console Started: 2017/12/01 08:15

cmsbuild · 2017-12-01T08:45:12Z

+1
Tested at: eab7f67
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21494/24896/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
9b38965
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21494/24896/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21494/24896/git-merge-result

cmsbuild · 2017-12-01T08:45:15Z

Comparison job queued.

cmsbuild · 2017-12-01T18:22:12Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21494/24896/summary.html

There are some workflows for which there are errors in the baseline:
10824.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 27
DQMHistoTests: Total histograms compared: 2715851
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2715674
DQMHistoTests: Total skipped: 176
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.709999999926 KiB( 23 files compared)
Checked 111 log files, 8 edm output root files, 27 DQM output files

cmsbuild · 2017-12-12T08:51:48Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-12-12T08:52:16Z

The code-checks are being triggered in jenkins.

As discussed in PR cms-sw#18805, the Fwd.h headers need a definition of the specific class they wrap. We do the same as we did for this PR by renaming th efile to *Defs.h and actually including HGCFETriggerDigi.

cmsbuild · 2017-12-12T08:52:51Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-12-12T08:55:35Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21494/2541

cmsbuild · 2017-12-12T08:56:12Z

Pull request #21494 was updated. @nsmith-, @cmsbuild, @kpedro88, @thomreis, @rekovic can you please check and sign again.

davidlange6 · 2017-12-12T09:42:50Z

please test

cmsbuild · 2017-12-12T09:43:20Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25040/console Started: 2017/12/12 10:44

cmsbuild · 2017-12-12T13:48:38Z

+1
Tested at: 9296439
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21494/25040/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
e2188ba
5ab70dd
8a33024
0a49f60
ef598b6
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21494/25040/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21494/25040/git-merge-result

cmsbuild · 2017-12-12T13:48:41Z

Comparison job queued.

cmsbuild · 2017-12-12T14:42:05Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21494/25040/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21494/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 27
DQMHistoTests: Total histograms compared: 2835241
DQMHistoTests: Total failures: 21
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2835042
DQMHistoTests: Total skipped: 178
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.659999999931 KiB( 23 files compared)
Checked 113 log files, 9 edm output root files, 27 DQM output files

kpedro88 · 2017-12-12T15:13:43Z

+1

davidlange6 · 2017-12-14T08:49:37Z

merge

cmsbuild added this to the CMSSW_10_0_X milestone Nov 30, 2017

cmsbuild added code-checks-pending comparison-pending l1-pending orp-pending pending-signatures tests-pending upgrade-pending labels Nov 30, 2017

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 30, 2017

kpedro88 reviewed Nov 30, 2017

View reviewed changes

cmsbuild added tests-started and removed tests-pending labels Nov 30, 2017

cmsbuild added tests-approved and removed tests-started labels Dec 1, 2017

cmsbuild added comparison-available and removed comparison-pending labels Dec 1, 2017

Teemperor force-pushed the MigratedHgcfetriggerdigifwdhHgcfetriggerdigidefsh branch from eab7f67 to 9296439 Compare December 12, 2017 08:51

cmsbuild removed code-checks-approved comparison-available tests-approved labels Dec 12, 2017

cmsbuild added comparison-pending tests-pending labels Dec 12, 2017

Migrated HGCFETriggerDigiFwd.h to HGCFETriggerDigiDefs.h

9296439

As discussed in PR cms-sw#18805, the Fwd.h headers need a definition of the specific class they wrap. We do the same as we did for this PR by renaming th efile to *Defs.h and actually including HGCFETriggerDigi.

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 12, 2017

cmsbuild added tests-started and removed tests-pending labels Dec 12, 2017

cmsbuild added tests-approved and removed tests-started labels Dec 12, 2017

cmsbuild added comparison-available and removed comparison-pending labels Dec 12, 2017

cmsbuild added upgrade-approved and removed upgrade-pending labels Dec 12, 2017

cmsbuild added orp-approved and removed orp-pending labels Dec 14, 2017

cmsbuild merged commit 31b46aa into cms-sw:master Dec 14, 2017

Teemperor deleted the MigratedHgcfetriggerdigifwdhHgcfetriggerdigidefsh branch December 19, 2017 08:47

Teemperor restored the MigratedHgcfetriggerdigifwdhHgcfetriggerdigidefsh branch December 19, 2017 10:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrated HGCFETriggerDigiFwd.h to HGCFETriggerDigiDefs.h #21494

Migrated HGCFETriggerDigiFwd.h to HGCFETriggerDigiDefs.h #21494

Teemperor commented Nov 30, 2017

Teemperor commented Nov 30, 2017

cmsbuild commented Nov 30, 2017

cmsbuild commented Nov 30, 2017

cmsbuild commented Nov 30, 2017

kpedro88 Nov 30, 2017

kpedro88 Dec 4, 2017

kpedro88 Dec 11, 2017

Teemperor Dec 12, 2017

davidlange6 commented Nov 30, 2017

cmsbuild commented Nov 30, 2017 •

edited

cmsbuild commented Dec 1, 2017

cmsbuild commented Dec 1, 2017

cmsbuild commented Dec 1, 2017

cmsbuild commented Dec 12, 2017

cmsbuild commented Dec 12, 2017

cmsbuild commented Dec 12, 2017

cmsbuild commented Dec 12, 2017

cmsbuild commented Dec 12, 2017

davidlange6 commented Dec 12, 2017

cmsbuild commented Dec 12, 2017 •

edited

cmsbuild commented Dec 12, 2017

cmsbuild commented Dec 12, 2017

cmsbuild commented Dec 12, 2017

kpedro88 commented Dec 12, 2017

davidlange6 commented Dec 14, 2017

Migrated HGCFETriggerDigiFwd.h to HGCFETriggerDigiDefs.h #21494

Migrated HGCFETriggerDigiFwd.h to HGCFETriggerDigiDefs.h #21494

Conversation

Teemperor commented Nov 30, 2017

Teemperor commented Nov 30, 2017

cmsbuild commented Nov 30, 2017

cmsbuild commented Nov 30, 2017

cmsbuild commented Nov 30, 2017

kpedro88 Nov 30, 2017

Choose a reason for hiding this comment

kpedro88 Dec 4, 2017

Choose a reason for hiding this comment

kpedro88 Dec 11, 2017

Choose a reason for hiding this comment

Teemperor Dec 12, 2017

Choose a reason for hiding this comment

davidlange6 commented Nov 30, 2017

cmsbuild commented Nov 30, 2017 • edited

cmsbuild commented Dec 1, 2017

cmsbuild commented Dec 1, 2017

cmsbuild commented Dec 1, 2017

cmsbuild commented Dec 12, 2017

cmsbuild commented Dec 12, 2017

cmsbuild commented Dec 12, 2017

cmsbuild commented Dec 12, 2017

cmsbuild commented Dec 12, 2017

davidlange6 commented Dec 12, 2017

cmsbuild commented Dec 12, 2017 • edited

cmsbuild commented Dec 12, 2017

cmsbuild commented Dec 12, 2017

cmsbuild commented Dec 12, 2017

kpedro88 commented Dec 12, 2017

davidlange6 commented Dec 14, 2017

cmsbuild commented Nov 30, 2017 •

edited

cmsbuild commented Dec 12, 2017 •

edited