Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce fake rate loose tracks #2151

Merged
merged 4 commits into from Jan 30, 2014

Conversation

cerati
Copy link
Contributor

@cerati cerati commented Jan 23, 2014

Bug fixes for these two problems resulting in higher fakerate for generalTracks collection (when highPurity selection is not made):

  1. Now we have highPurity without corresponding loose/tight selection => need to explicitly set loose and tight when highPurity is passed
  2. New highPurity selection had flag keepAllTracks=True so that, for some iterations, tracks not even passing loose cuts were saved in generalTracks collection

For more info:
https://indico.cern.ch/getFile.py/access?contribId=23&sessionId=5&resId=0&materialId=slides&confId=295861

This is meant to go in 700 (and 71X of course)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @cerati for CMSSW_7_0_X.

Reduce fake rate loose tracks

It involves the following packages:

RecoTracker/FinalTrackSelectors
RecoTracker/IterativeTracking

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@gpetruc, @ghellwig, @GiacomoSguazzoni, @rovere this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Jan 27, 2014

Here are some notes from comparisons in CMSSW_7_0_X_2014-01-20-1400 (using 05ce46e of this PR)
part-1: fwlite scripts (not DQM)

[ @cerati @rovere Giuseppe and Marco, please comment on the muon iteration migration noted below]

In general changes are as expected:

  • higher pileup samples have larger drop in general tracks, even more visible in the conversion step tracks
  • pflow and egamma objects don't change much (thanks to preselection)

Unclear or somewhat suspicious changes:

  • for hadron or electron-dominated samples the generalTracks are suppressed primarily in the algo=9 (iter5).
    e.g. in TTBar with 2012-like PU (wflow 202)
    all_sign299vsorig_ttbarpuwf202p0c_recotracks_generaltracks__reco_obj_algo
  • muon gun samples have a drop in algo=10 as well (OK), but there is a major migration of algo=4 (iter0) tracks to algo=13, the muon-seeded iteration, e.g., muon gun pt=20 GeV
    all_sign299vsorig_singlemupt10wf20p0c_recotracks_generaltracks__reco_obj_algo
    A visible side-effect for this is that the stored MVA value is now predominantly not computed (-99).
  • TeV muon sample now has a significant increase in electron seeds with fairly long tracks (is it due to some preference to iterations used for ele seeding?) The number of particle flow EGamma candidate electrons actually goes down (more efficient rejection by overlap)
    all_sign299vsorig_singlemupt1000wf22p0c_recoelectronseeds_electronmergedseeds__reco_obj_nhits
  • high-pu sample (TTBar 2012-PU here) show a large decrease in PF displaced vertices at .. still consistent with reduction of fakes
    all_sign299vsorig_ttbarpuwf202p0c_recopfdisplacedvertexs_particleflowdisplacedvertex__reco_obj_nsecondarytracks

@slava77
Copy link
Contributor

slava77 commented Jan 27, 2014

small follow-up to the above:
DQM plot of the track quality (qualityMask() ) in mu pt=10 GeV (correction to the above: change pt=20 to pt=10 geV). This looks like "confirmed" bit is not set in this case.
Should this be happening?

screen shot 2014-01-27 at 1 53 40 pm

@slava77
Copy link
Contributor

slava77 commented Jan 28, 2014

+1

tested eb11f25 in CMSSW_7_0_X_2014-01-20-1400 (sign299a test area).
The last commit fixed the odd distribution mentioned above.

This PR is for 700pre13

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (tests are also fine). @ktf can you please take care of it?

ktf added a commit that referenced this pull request Jan 30, 2014
Reco updates -- Reduce fake rate loose tracks
@ktf ktf merged commit bd2bc7e into cms-sw:CMSSW_7_0_X Jan 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants