New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected include in EcalWeightSetXMLTranslator.h #21538
Corrected include in EcalWeightSetXMLTranslator.h #21538
Conversation
We use DOMElement and not DOMNode in this header, so we also need to include the DOMElement header to make this file parsable on its own.
Part of the work going on regarding the C++ modules migration of CMSSW (tracked as issue #15248). This PR is not meant to refactor things, but just to make these headers compile. |
The code-checks are being triggered in jenkins. |
+code-checks |
A new Pull Request was created by @Teemperor (Raphael Isemann) for master. It involves the following packages: CondTools/Ecal @ggovi, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready There are some workflows for which there are errors in the baseline: Comparison Summary:
|
merge |
We use DOMElement and not DOMNode in this header, so we also need
to include the DOMElement header to make this file parsable on its
own.