New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include TEveVector.h in FWPFMaths.h #21605
Include TEveVector.h in FWPFMaths.h #21605
Conversation
We return TEveVector in this header by value from a few functions, so we actually have to include the TEveVector.h header to get the defintion of TEveVector and make this header parsable on its own.
Part of the work going on regarding the C++ modules migration of CMSSW (tracked as issue #15248). This PR is not meant to refactor things, but just to make these headers compile. |
The code-checks are being triggered in jenkins. |
+code-checks |
A new Pull Request was created by @Teemperor (Raphael Isemann) for master. It involves the following packages: Fireworks/ParticleFlow @cmsbuild, @alja, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped) |
merge |
We return TEveVector in this header by value from a few functions, so
we actually have to include the TEveVector.h header to get the
defintion of TEveVector and make this header parsable on its own.