[10X] [L1T] [DQM] Updating range for vertex histogram #21615
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
A new Pull Request was created by @kreczko (Luke Kreczko) for master. It involves the following packages: DQMOffline/L1Trigger @cmsbuild, @vazzolini, @kmaeshima, @dmitrijus, @nsmith-, @rekovic, @jfernan2, @thomreis, @vanbesien can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Hi @kreczko could you also make a 94x backport PR of this one please? |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Out of curiosity why?
On 30 Nov 2017, at 08:01, Thomas Reis <notifications@github.com<mailto:notifications@github.com>> wrote:
Hi @kreczko<https://github.com/kreczko> could you also make a 94x backport PR of this one please?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#21615 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEzywzxE2_uPi51gpFZ0czh86iGbTvxTks5s7rUagaJpZM4QwbOf>.
|
|
Because I thought that an eventual re-reco of 2017 data with 94x will also include DQM. |
|
Comparison is ready Comparison Summary:
|
|
Right but It that rereco is underway...
On 30 Nov 2017, at 23:29, Thomas Reis <notifications@github.com<mailto:notifications@github.com>> wrote:
Because I thought that an eventual re-reco of 2017 data with 94x will also include DQM.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#21615 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEzywzvHq11Dp0dcWZjxhuns_AbFt4udks5s7zoggaJpZM4QwbOf>.
|
|
+1 |
|
Pull request #21615 was updated. @cmsbuild, @vazzolini, @kmaeshima, @dmitrijus, @nsmith-, @rekovic, @jfernan2, @thomreis, @vanbesien can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+1 |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
@davidlange6 can this be reviewed/merged please? |
|
+1 |
Fixes issue https://its.cern.ch/jira/browse/CMSLITDPG-328:
increased the max nVertex value from 40 to 100.
Since 3 modules use the same definition, I've added the functionality,
dqmoffline::l1t::HistDefinition, to define such limits in python. TheL1TEGammaOffline,L1TStage2CaloLayer2Offline, andL1TTauOfflinemodules are now using the samenVertexhistogram definition.Of course,
dqmoffline::l1t::HistDefinitionwould technically allow for all definitions to come from the python file, which could be shared across modules. This might be addressed in a later PR.