Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fireworks: increase span of energy scale in lego view #21642

Merged
merged 1 commit into from Dec 5, 2017
Merged

Fireworks: increase span of energy scale in lego view #21642

merged 1 commit into from Dec 5, 2017

Conversation

alja
Copy link
Contributor

@alja alja commented Dec 4, 2017

This is a request from HF team.

@alja
Copy link
Contributor Author

alja commented Dec 4, 2017

+1

@cmsbuild cmsbuild added this to the CMSSW_10_0_X milestone Dec 4, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2017

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21642/2417

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2017

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2017

A new Pull Request was created by @alja (Alja Mrak-Tadel) for master.

It involves the following packages:

Fireworks/Core

@cmsbuild can you please review it and eventually sign? Thanks.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

This was referenced Dec 4, 2017
Merged
Merged
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2017

+1
Tested at: 3a84ebc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21642/24929/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
632b6c0
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21642/24929/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21642/24929/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2017

Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9b3338e into cms-sw:master Dec 5, 2017
@alja alja deleted the patch-1 branch April 8, 2020 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved comparison-notrun fully-signed orp-approved tests-approved visualization-approved
Projects
None yet
Milestone
CMSSW_10_0_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alja @cmsbuild @davidlange6