L1T muon unpacker fix for crash with corrupt uGT RO record

[thomreis]

This addresses the issue cms-l1t-offline#642
The L1T muon unpacker was crashing when encountering an event with a corrupt uGT readout record.

Throwing an exception if a corrupt RO record is encountered since this data should not be used.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21665/2506

[cmsbuild]

A new Pull Request was created by @thomreis (Thomas Reis) for master.

It involves the following packages:

DataFormats/L1Trigger
EventFilter/L1TRawToDigi

@nsmith-, @cmsbuild, @thomreis, @rekovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko, @rovere this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[thomreis]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25005/console Started: 2017/12/08 12:51

[thomreis]

type bugfix

[cmsbuild]

+1
Tested at: da0ae5f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21665/25005/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
623a831
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21665/25005/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21665/25005/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21665/25005/summary.html

The workflows 1003.0, 1001.0, 1000.0, 140.53, 136.7611, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21665/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2835241
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2835062
• DQMHistoTests: Total skipped: 178
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.05000000002 KiB( 23 files compared)
• Checked 113 log files, 9 edm output root files, 27 DQM output files

[cmsbuild]

The code-checks are being triggered in jenkins.

[thomreis]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21665/2543

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25043/console Started: 2017/12/12 11:24

[cmsbuild]

Pull request #21665 was updated. @nsmith-, @cmsbuild, @thomreis, @rekovic can you please check and sign again.

[cmsbuild]

+1
Tested at: 58a2aec
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21665/25043/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
ef598b6
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21665/25043/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21665/25043/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21665/25043/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21665/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2835241
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2835062
• DQMHistoTests: Total skipped: 178
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.00999999997 KiB( 23 files compared)
• Checked 113 log files, 9 edm output root files, 27 DQM output files

[thomreis]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

merge