Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread safety bugfix in CSCGEMMotherboardME11 #21671

Merged
merged 1 commit into from Dec 8, 2017
Merged

Thread safety bugfix in CSCGEMMotherboardME11 #21671

merged 1 commit into from Dec 8, 2017

Conversation

dildick
Copy link
Contributor

@dildick dildick commented Dec 8, 2017

In response to #21670.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2017

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21671/2512

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2017

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

L1Trigger/CSCTriggerPrimitives

@nsmith-, @cmsbuild, @thomreis, @rekovic can you please review it and eventually sign? Thanks.
@valuev, @ptcox, @kreczko, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@thomreis
Copy link
Contributor

thomreis commented Dec 8, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25010/console Started: 2017/12/08 17:25

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2017

Comparison job queued.

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit c14b99b into cms-sw:master Dec 8, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21671/25010/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21671/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2835241
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2835062
  • DQMHistoTests: Total skipped: 178
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.09999999998 KiB( 23 files compared)
  • Checked 113 log files, 9 edm output root files, 27 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants