Herwig7.1.2 Interface in CMSSW #21711

Andrej-CMS · 2017-12-14T10:44:11Z

code-checks thepeg added to Buildfile added thepeg code checks code-checks fix for 94X removed cmsgrid_final.lhe added python fragments for cmsDriver. These can be used to create a cmsRun config according to the CMSSW release. changed to range loop. different treatment if runmode has no comma removed mutable. using insert instead of for loop removed 'process' removed obsolete configs added example configs, see cmsDriver.py command fix comparison between uint and int removed test couts for debugging

cmsbuild · 2017-12-14T10:44:39Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-12-14T10:48:03Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21711/2586

cmsbuild · 2017-12-14T10:48:35Z

A new Pull Request was created by @Andrej-CMS for master.

It involves the following packages:

GeneratorInterface/Herwig7Interface

The following packages do not have a category, yet:

GeneratorInterface/Herwig7Interface
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@cmsbuild can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2017-12-14T21:11:56Z

Pull request #21711 was updated. @cmsbuild, @efeyazgan, @perrozzi can you please check and sign again.

perrozzi · 2017-12-14T21:28:49Z

please test with #21052 cms-sw/cmsdist#3519

cmsbuild · 2017-12-14T21:29:25Z

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#3519
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25110/console

cmsbuild · 2017-12-15T01:28:21Z

+1
Tested at: 8e65618
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21711/25110/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
9543bd0
45a2438
566160a
33f1e74
40c0ef7
57b9354
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21711/25110/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21711/25110/git-merge-result

cmsbuild · 2017-12-15T01:28:27Z

Comparison job queued.

cmsbuild · 2017-12-15T02:50:16Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21711/25110/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21711/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 26
DQMHistoTests: Total histograms compared: 2777593
DQMHistoTests: Total failures: 105
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2777317
DQMHistoTests: Total skipped: 171
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
Checked 109 log files, 9 edm output root files, 26 DQM output files

perrozzi · 2017-12-15T06:33:33Z

+1

fabiocos · 2018-01-15T12:30:23Z

please test workflow 511.0 with #21052 cms-sw/cmsdist#3642

cmsbuild · 2018-01-15T12:30:42Z

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#3642
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25445/console

cmsbuild · 2018-01-15T14:26:52Z

+1
Tested at: d167e90
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21711/25445/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
6162146
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21711/25445/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21711/25445/git-merge-result

cmsbuild · 2018-01-15T14:26:59Z

Comparison job queued.

cmsbuild · 2018-01-15T15:12:39Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21711/25445/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21711/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017
/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21711/511.0_QCD_Pt-30_13TeV_aMCatNLO_herwig7+QCD_Pt-30_13TeV_aMCatNLO_herwig7+HARVESTGEN

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 26
DQMHistoTests: Total histograms compared: 2467599
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2467429
DQMHistoTests: Total skipped: 169
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.989999999983 KiB( 22 files compared)
Checked 110 log files, 9 edm output root files, 26 DQM output files

perrozzi · 2018-01-15T15:26:15Z

+1

fabiocos · 2018-01-16T08:45:15Z

@kpedro88, @fabozzi this PR requires your signature after (successful) test, could you please provide it? As far as I can see we can integrate the new generator in pre4 for more extensive technical and physics tests. Otherwise please formulate your remarks.

fabozzi · 2018-01-16T08:57:14Z

+1

kpedro88 · 2018-01-16T15:06:59Z

+1

cmsbuild · 2018-01-16T15:07:22Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2018-01-16T15:13:07Z

merge

cmsbuild added this to the CMSSW_10_0_X milestone Dec 14, 2017

cmsbuild added code-checks-pending comparison-pending new-package-pending orp-pending pending-signatures tests-pending labels Dec 14, 2017

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 14, 2017

cmsbuild added generators-pending and removed new-package-pending labels Dec 14, 2017

cmsbuild mentioned this pull request Dec 14, 2017

Herwig 7.1.1 with External NLO Matrix Element Providers cms-sw/cmsdist#3519

Closed

cmsbuild added requires-external tests-started and removed tests-pending labels Dec 14, 2017

cmsbuild added tests-approved and removed tests-started labels Dec 15, 2017

cmsbuild added comparison-available and removed comparison-pending labels Dec 15, 2017

cmsbuild added requires-external tests-started and removed tests-pending labels Jan 15, 2018

cmsbuild added tests-approved and removed tests-started labels Jan 15, 2018

cmsbuild added comparison-available and removed comparison-pending labels Jan 15, 2018

cmsbuild added generators-approved and removed generators-pending labels Jan 15, 2018

cmsbuild added pdmv-approved and removed pdmv-pending labels Jan 16, 2018

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Jan 16, 2018

cmsbuild added orp-approved and removed orp-pending labels Jan 16, 2018

cmsbuild merged commit 52ba2cf into cms-sw:master Jan 16, 2018

alberto-sanchez mentioned this pull request Jan 8, 2019

Herwig7Interface backport 9_3_X #25484

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Herwig7.1.2 Interface in CMSSW #21711

Herwig7.1.2 Interface in CMSSW #21711

Andrej-CMS commented Dec 14, 2017

cmsbuild commented Dec 14, 2017

cmsbuild commented Dec 14, 2017

cmsbuild commented Dec 14, 2017 •

edited by smuzaffar

cmsbuild commented Dec 14, 2017

perrozzi commented Dec 14, 2017

cmsbuild commented Dec 14, 2017 •

edited

cmsbuild commented Dec 15, 2017

cmsbuild commented Dec 15, 2017

cmsbuild commented Dec 15, 2017

perrozzi commented Dec 15, 2017

fabiocos commented Jan 15, 2018

cmsbuild commented Jan 15, 2018 •

edited

cmsbuild commented Jan 15, 2018

cmsbuild commented Jan 15, 2018

cmsbuild commented Jan 15, 2018

perrozzi commented Jan 15, 2018

fabiocos commented Jan 16, 2018

fabozzi commented Jan 16, 2018

kpedro88 commented Jan 16, 2018

cmsbuild commented Jan 16, 2018

fabiocos commented Jan 16, 2018

Herwig7.1.2 Interface in CMSSW #21711

Herwig7.1.2 Interface in CMSSW #21711

Conversation

Andrej-CMS commented Dec 14, 2017

cmsbuild commented Dec 14, 2017

cmsbuild commented Dec 14, 2017

cmsbuild commented Dec 14, 2017 • edited by smuzaffar

cmsbuild commented Dec 14, 2017

perrozzi commented Dec 14, 2017

cmsbuild commented Dec 14, 2017 • edited

cmsbuild commented Dec 15, 2017

cmsbuild commented Dec 15, 2017

cmsbuild commented Dec 15, 2017

perrozzi commented Dec 15, 2017

fabiocos commented Jan 15, 2018

cmsbuild commented Jan 15, 2018 • edited

cmsbuild commented Jan 15, 2018

cmsbuild commented Jan 15, 2018

cmsbuild commented Jan 15, 2018

perrozzi commented Jan 15, 2018

fabiocos commented Jan 16, 2018

fabozzi commented Jan 16, 2018

kpedro88 commented Jan 16, 2018

cmsbuild commented Jan 16, 2018

fabiocos commented Jan 16, 2018

cmsbuild commented Dec 14, 2017 •

edited by smuzaffar

cmsbuild commented Dec 14, 2017 •

edited

cmsbuild commented Jan 15, 2018 •

edited