Fixing lack of virtualness for some GsfElectron methods : 94X

[Sam-Harper]

This is a bug fix backport #21708

which would be nice so we can update our code to take advantage of this in 94X and 10X code.

[cmsbuild]

A new Pull Request was created by @Sam-Harper for CMSSW_9_4_X.

It involves the following packages:

DataFormats/EgammaCandidates
DataFormats/PatCandidates

@perrotta, @cmsbuild, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@gouskos, @jainshilpi, @rovere, @lgray, @cbernet, @gpetruc, @varuns23 this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Fixing lack of virtualness for some GsfElectron methods #21708

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25129/console Started: 2017/12/15 19:54

[cmsbuild]

+1
Tested at: dc9e7bb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21731/25129/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21731/25129/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21731/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2777593
• DQMHistoTests: Total failures: 103
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2777319
• DQMHistoTests: Total skipped: 171
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
• Checked 109 log files, 9 edm output root files, 26 DQM output files

[slava77]

+1

for #21731 dc9e7bb

• somewhat technical changes needed for analysis; the backport of Fixing lack of virtualness for some GsfElectron methods #21708 is correct
• jenkins tests pass

[slava77]

backport of #21708

[fabiocos]

merge