Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New z coordinates for pixelphase1 disks (Carlo) #2174

Merged
merged 1 commit into from Jan 27, 2014

Conversation

boudoul
Copy link
Contributor

@boudoul boudoul commented Jan 26, 2014

New positions of pixel fwd disks (pixel Phase1) according to the latest eneginer design .

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @boudoul (boudoul) for CMSSW_6_2_X_SLHC.

New z coordinates for pixelphase1 disks (Carlo)

It involves the following packages:

Geometry/TrackerCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@boudoul
Copy link
Contributor Author

boudoul commented Jan 26, 2014

Tested with
runTheMatrix.py --what upgrade 4400,3300

@mark-grimes
Copy link

merge

Normal upgrade matrix tests 3300, 3400, 4100, 4400, 40001, 50002, 60002, 60001, 4502, 4500, 5001, 15001 and 50001 all pass. Also tried 3400 with combinedCustoms.cust_2019WithGem since none of the current tests check the GEMs. Got a failure in step4 with:

----- Begin Fatal Exception 27-Jan-2014 01:09:36 CET-----------------------
An exception of category 'MonitorElement' occurred while
   [0] Processing run: 1
   [1] Running path 'validationHarvesting'
   [2] Calling endRun for module HcalDigisClient/'hcaldigisClient'
Exception Message:
Method 'void MonitorElement::Fill(double, double)' cannot be invoked on monitor element 'UH<89><F5>SH<89><FB>H<83><EC>^H<E8><8F>^D<FB><FF>H<83>8'
----- End Fatal Exception -------------------------------------------------

I don't consider this relevant to this pull request, it just wasn't caught before because it's not part of the current tests. Probably an issue with the HCal code currently being fixed. I'll chase it up separately.

cmsbuild added a commit that referenced this pull request Jan 27, 2014
New z coordinates for pixelphase1 disks (Carlo)
@cmsbuild cmsbuild merged commit e878463 into cms-sw:CMSSW_6_2_X_SLHC Jan 27, 2014
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Update frontier client to 2.8.18.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants