Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep HI Gen collections when pp reco is customized for XeXe (94X back… #21761

Merged
merged 1 commit into from Jan 18, 2018

Conversation

mandrenguyen
Copy link
Contributor

For certain MC productions it's necessary to keep information about the geometry of colliding nuclei for centrality determination.
The heavy ion eras keep these collections, as the heavy ion event content stores them:
SimGeneral/Configuration/python/SimGeneral_HiMixing_EventContent_cff.py
However, for XeXe we use the standard pp event content.
This PR expands that event content for the XeXe era.
The extra collection is stored in the DIGI and RECO steps:
edm::GenHIEvent "heavyIon" "" "HLT"

This is a backport of #21760

@gsfs

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for CMSSW_9_4_X.

It involves the following packages:

SimGeneral/Configuration

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor

civanch commented Jan 3, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 3, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25309/console Started: 2018/01/03 23:26

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 4, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 4, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 4, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21761/25309/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21761/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 25
  • DQMHistoTests: Total histograms compared: 2717599
  • DQMHistoTests: Total failures: 111
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2717326
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 106 log files, 9 edm output root files, 25 DQM output files

@civanch
Copy link
Contributor

civanch commented Jan 4, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 4, 2018

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c57e35b into cms-sw:CMSSW_9_4_X Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants