migrate to concurrent DQM

[fwyzard]

No description provided.

[fwyzard]

An alternative implementation of #21764, for reference.

[cmsbuild]

The code-checks are being triggered in jenkins.

[fwyzard]

@cmsbuild, please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21766/2730

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

DQMOffline/RecoB

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@swertz, @imarches, @acaudron, @JyothsnaKomaragiri, @mverzett, @ferencek, @pvmulder, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21766/2731

[cmsbuild]

Pull request #21766 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please check and sign again.

[fwyzard]

@cmsbuild, please test

[cmsbuild]

+1
Tested at: 883af21
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21766/25250/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21766/25250/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21766/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2773742
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2773572
• DQMHistoTests: Total skipped: 169
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.580000000096 KiB( 22 files compared)
• Checked 110 log files, 9 edm output root files, 26 DQM output files

[fwyzard]

I understand that @VinInn is OK with these changes.

@vazzolini, @kmaeshima, @dmitrijus, could please sign or comment ?

[dmitrijus]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1

[Dr15Jones]

This pull request is causing a crash in the IBs.
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc630/CMSSW_10_0_X_2018-01-17-1100/pyRelValMatrixLogs/run/5.4_ZEE+ZEEFS+HARVESTFS/step1_ZEE+ZEEFS+HARVESTFS.log

The problem is DTSegment2DSLPhiQuality is a legacy EDAnalyzer which does NOT inherit from DQMEDAnalyzer. The module is calling directly into the DQMStore at global begin Run and happens to do it at the exact same time as PrimaryVertexMonitor.

[Dr15Jones]

DTSegment2DSLPhiQuality did not cause a problem previously because the DQMEDAnalyzers were all stream modules so they filled their histograms at streamBeginRun and streamBeginLuminosityBlock which happen after their global counterparts.

[Dr15Jones]

DTRecHitQuality is also causing crashes in the beginRun for the same reason as DTSegment2DSLPhiQuality.

https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc630/CMSSW_10_0_X_2018-01-17-1100/pyRelValMatrixLogs/run/5.6_QCD_FlatPt_15_3000+QCDFlatPt153000FS+HARVESTFS/step1_QCD_FlatPt_15_3000+QCDFlatPt153000FS+HARVESTFS.log

[fabiocos]

@fwyzard @Dr15Jones given that we need to converge for pre4, I will revert the PR in case we do not have quickly a fix

[Dr15Jones]

DTSegment4DQuality is also causing crashes:
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc700/CMSSW_10_0_X_2018-01-17-1100/pyRelValMatrixLogs/run/5.3_SingleMuPt100+SingleMuPt100FS+HARVESTFS/step1_SingleMuPt100+SingleMuPt100FS+HARVESTFS.log

[VinInn]

Do I understand correctly that before any module is migrated to the new concurrent DQM DTSegment2DSLPhiQuality need to be fixed (as well as any other module operating in the same way)?
@kmaeshima, @dmitrijus please take note

[dmitrijus]

Reverting this PR will not solve the issue...

I will migrate/disable DTSegment2DSLPhiQuality later today.

[fwyzard]

Do I understand correctly that before any module is migrated to the new concurrent DQM DTSegment2DSLPhiQuality need to be fixed (as well as any other module operating in the same way)?

Correct.