New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed EventSetup::iovSyncValue call from TrackingRecHitProducer #21779
Conversation
The TrackingRecHitProducer was using EventSetup::iovSyncValue to determine if it needed to update its cache from tracking geometry. The proper way to do that is to use the cacheIdentifier from each EventSetup record which is being used. In addition, the EventSetup::iovSyncValue call will be removed in the near future.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21779/2744 |
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: FastSimulation/TrackingRecHitProducer @cmsbuild, @ssekmen, @civanch, @mdhildreth, @lveldere can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
merge |
The TrackingRecHitProducer was using EventSetup::iovSyncValue to
determine if it needed to update its cache from tracking geometry.
The proper way to do that is to use the cacheIdentifier from each
EventSetup record which is being used.
In addition, the EventSetup::iovSyncValue call will be removed
in the near future.