New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
catch-up update to #21775 in JetFlavourClustering #21781
Conversation
The code-checks are being triggered in jenkins. |
@cmsbuild please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21781/2746 |
The tests are being triggered in jenkins. |
A new Pull Request was created by @slava77 (Slava Krutelyov) for master. It involves the following packages: PhysicsTools/JetMCAlgos @cmsbuild, @monttj can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
merge |
this is a catch-up improvement to #21775 to reserve for the lepton size as well when it's used.
I also played a bit with the std::move in
fjClusterSeq_ = ClusterSequencePtr( new fastjet::ClusterSequence( fjInputs, *fjJetDefinition_ ) );
, as it seemed to improve the memory peak at first, but after re-sampling/rerunning a few times I could not see a significant improvement.