Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ME3/1 ME4/1 Phase-2 upgrade TMB #21785

Merged
merged 4 commits into from Jan 26, 2018
Merged

ME3/1 ME4/1 Phase-2 upgrade TMB #21785

merged 4 commits into from Jan 26, 2018

Conversation

dildick
Copy link
Contributor

@dildick dildick commented Dec 23, 2017

In the past we had ME3/1 and ME4/1 OTMBs with RPC digis. I scrapped those a while ago, since RPC digis will not be sent to the local trigger. An OTMB class for ME3/1 and ME4/1 without RPCs was constructed. Those OTMBs are based on the ME1/1 OTMB for high-pileup running, but they are a lot simpler because (1) the wiregroups are not slanted and (2) the chambers are not divided into two readout sectors for halfstrips.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

L1Trigger/CSCTriggerPrimitives

@nsmith-, @cmsbuild, @thomreis, @rekovic can you please review it and eventually sign? Thanks.
@valuev, @ptcox, @kreczko, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 23, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25274/console Started: 2017/12/23 22:44

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21785/25274/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21785/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2773742
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2773572
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.780000000006 KiB( 22 files compared)
  • Checked 110 log files, 9 edm output root files, 26 DQM output files

@dildick
Copy link
Contributor Author

dildick commented Jan 10, 2018

@rekovic can you inspect and sign please?

@rekovic
Copy link
Contributor

rekovic commented Jan 11, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 11, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25367/console Started: 2018/01/11 11:34

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21785/25367/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21785/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2774843
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2774673
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.15999999999 KiB( 22 files compared)
  • Checked 110 log files, 9 edm output root files, 26 DQM output files

@rekovic
Copy link
Contributor

rekovic commented Jan 15, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@dildick
Copy link
Contributor Author

dildick commented Jan 18, 2018

Could this PR be integrated, please?

@dildick
Copy link
Contributor Author

dildick commented Jan 22, 2018

@fabiocos Could you please merge this PR?

@smuzaffar smuzaffar modified the milestones: CMSSW_10_0_X, CMSSW_10_1_X Jan 24, 2018
@dildick
Copy link
Contributor Author

dildick commented Jan 24, 2018

@davidlange6 Could you please merge this PR?

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2e4ebdd into cms-sw:master Jan 26, 2018
@dildick dildick deleted the from-CMSSW_10_0_X_2017-12-20-2300-me3141-tmb branch January 28, 2018 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants