New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ME3/1 ME4/1 Phase-2 upgrade TMB #21785
ME3/1 ME4/1 Phase-2 upgrade TMB #21785
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21785/2753 |
A new Pull Request was created by @dildick (Sven Dildick) for master. It involves the following packages: L1Trigger/CSCTriggerPrimitives @nsmith-, @cmsbuild, @thomreis, @rekovic can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
@rekovic can you inspect and sign please? |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
Could this PR be integrated, please? |
@fabiocos Could you please merge this PR? |
@davidlange6 Could you please merge this PR? |
+1 |
In the past we had ME3/1 and ME4/1 OTMBs with RPC digis. I scrapped those a while ago, since RPC digis will not be sent to the local trigger. An OTMB class for ME3/1 and ME4/1 without RPCs was constructed. Those OTMBs are based on the ME1/1 OTMB for high-pileup running, but they are a lot simpler because (1) the wiregroups are not slanted and (2) the chambers are not divided into two readout sectors for halfstrips.