Phase2-hgx91 Change the signature of CaloCellGeometry

[bsunanda]

Use std::shared_ptr for accessing the CaloCellGeometry so that new Cell pointers can be created on demand (useful for HGCal and also Hcal).

This is a copy of PR# 21440 which has a merge conflict and could not be recovered. #21440 will be closed once this PR is merged

[cmsbuild]

The code-checks are being triggered in jenkins.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21808/2796

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25318/console Started: 2018/01/06 00:10

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

CalibCalorimetry/EcalTPGTools
Calibration/EcalAlCaRecoProducers
Calibration/EcalCalibAlgos
Calibration/HcalAlCaRecoProducers
Calibration/HcalCalibAlgos
Calibration/IsolatedParticles
Calibration/Tools
CondTools/Geometry
DQM/EcalMonitorTasks
DQMOffline/CalibCalo
DQMOffline/EGamma
DQMOffline/Ecal
DQMOffline/Hcal
DQMOffline/JetMET
DataFormats/ParticleFlowReco
FastSimulation/CaloGeometryTools
Fireworks/Geometry
Geometry/CaloEventSetup
Geometry/CaloGeometry
Geometry/CaloTopology
Geometry/EcalAlgo
Geometry/EcalTestBeam
Geometry/ForwardGeometry
Geometry/HGCalGeometry
Geometry/HcalTowerAlgo
HiggsAnalysis/HiggsToGammaGamma
JetMETCorrections/MinBias
L1Trigger/L1THGCal
RecoBTau/JetCrystalsAssociator
RecoEcal/EgammaClusterAlgos
RecoEcal/EgammaClusterProducers
RecoEcal/EgammaCoreTools
RecoEgamma/EgammaHFProducers
RecoEgamma/EgammaHLTProducers
RecoEgamma/EgammaIsolationAlgos
RecoEgamma/EgammaTools
RecoJets/JetProducers
RecoLocalCalo/CaloTowersCreator
RecoLocalCalo/EcalRecProducers
RecoLocalCalo/HGCalRecAlgos
RecoLocalCalo/HcalRecAlgos
RecoLocalFastTime/FTLCommonAlgos
RecoMET/METAlgorithms
RecoMET/METFilters
RecoParticleFlow/PFClusterProducer
RecoParticleFlow/PFSimProducer
RecoTBCalo/EcalSimpleTBAnalysis
RecoTBCalo/EcalTBAnalysisCoreTools
RecoTauTag/RecoTau
SUSYBSMAnalysis/HSCP
SimCalorimetry/CaloSimAlgos
SimCalorimetry/EcalEBTrigPrimProducers
SimCalorimetry/EcalSimAlgos
SimCalorimetry/EcalTrigPrimProducers
TrackingTools/TrackAssociator
Validation/EcalDigis
Validation/GlobalHits
Validation/GlobalRecHits
Validation/HGCalValidation
Validation/HcalDigis
Validation/HcalHits
Validation/HcalRecHits

@ghellwig, @lveldere, @ianna, @kpedro88, @nsmith-, @rekovic, @thomreis, @vanbesien, @perrotta, @civanch, @monttj, @silviodonato, @cmsbuild, @fwyzard, @Dr15Jones, @mdhildreth, @jfernan2, @cerminar, @slava77, @ggovi, @Martin-Grunewald, @ssekmen, @vazzolini, @kmaeshima, @arunhep, @dmitrijus, @alja, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @rappoccio, @gouskos, @yslai, @felicepantaleo, @jainshilpi, @abbiendi, @TaiSakuma, @kpedro88, @argiro, @Martin-Grunewald, @imarches, @pfs, @ahinzmann, @varuns23, @seemasharmafnal, @mmarionncern, @kreczko, @sethzenz, @JyothsnaKomaragiri, @makortel, @acaudron, @jhgoh, @lgray, @mmusich, @jdolen, @HuguesBrun, @drkovalskyi, @ferencek, @trocino, @rociovilar, @vandreev11, @Sam-Harper, @GiacomoSguazzoni, @tocheng, @VinInn, @jdamgov, @bellan, @nhanvtran, @gkasieczka, @rovere, @schoef, @ebrondol, @dgulhan, @cseez, @calderona, @battibass, @edjtscott, @alja, @mverzett, @folguera, @cbernet, @gpetruc, @matt-komm, @mariadalfonso, @amarini, @pvmulder, @bachtis, @jbsauvan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 6a773c5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21808/25318/summary.html

[cmsbuild]

Comparison job queued.

[rekovic]

+1

[civanch]

+1

[bsunanda]

@ggovi @dmitrijus @alja Can you approve this please

[bsunanda]

@fabiocos Could you please take this PR into the IB and to pre4?

[fabiocos]

Is this PR ok for db and dqm? It is quite complex, we should try to move it forward asap, thanks

[bsunanda]

@fabiocos @ggovi @dmitrijus The real change is the use of CaloCellGeometry object. The pointer for this is now a shared_ptr rather than a normal one. The main impact is on geometry and reco code. In other parts some casting styles are changed and a bug in HGCal code is corrected.

[dmitrijus]

+1

[ggovi]

+1

[fabiocos]

@alja Sorry, but we need to move forward with this PR

[fabiocos]

merge

[davidlt]

This is wrong. This will result in infinite recursion until the stack is exhausted.

[bsunanda]

I am making a new PR (#21913) to correct this - please check that. Sorry I overlooked this. Regards Sunanda

________________________________ From: davidlt [notifications@github.com] Sent: 22 January 2018 16:33 To: cms-sw/cmssw Cc: Sunanda Banerjee; Mention Subject: Re: [cms-sw/cmssw] Phase2-hgx91 Change the signature of CaloCellGeometry (#21808) @davidlt commented on this pull request.

________________________________ In Geometry/CaloGeometry/interface/FlatTrd.h<#21808 (comment)>:

@@ -71,13 +71,16 @@ class FlatTrd : public CaloCellGeometry {

void getTransform( Tr3D& tr, Pt3DVec* lptr ) const override; + void setPosition ( const GlobalPoint& p ) { m_global = p; setRefPoint(p); } + void setBackPoint( const GlobalPoint& p ) { setBackPoint(p); } This is wrong. This will result in infinite recursion until the stack is exhausted. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#21808 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEzMun1ZWJeJCTb1VsC_Q6z3zJSvqYDrks5tNKo-gaJpZM4RVDcN>.