Adding PFClusterIsolation to reco Egamma objects #21811
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21811/2802 |
|
A new Pull Request was created by @Sam-Harper for master. It involves the following packages: DataFormats/EgammaCandidates @perrotta, @cmsbuild, @monttj, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
|
||
| ootPhotons = _gedPhotons.clone( | ||
| photonProducer = 'ootPhotonsTmp', | ||
| candidateP4type = "fromEcalEnergy", |
There was a problem hiding this comment.
@Sam-Harper , checking https://github.com/Sam-Harper/cmssw/blob/6e6a25fd65e53bbf5a43d99fecab8a2f46712896/RecoEgamma/EgammaPhotonProducers/src/GEDPhotonProducer.cc#L841-L843, this means that the regression is effectively skipped in the final step for ootPhotons, correct?
I guess the nice thing here is that, now the symmetry between ged and oot photons is closer with a tmp and final step for both, even if nothing really happens in the final step for oot photons.
There was a problem hiding this comment.
Yes, the intention was to skip the regression for OOT photons.
|
-1 Tested at: 6e6a25f You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals AddOn
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/136.7611_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM/step2_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM.log140.53 step2 runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log
I found errors in the following addon tests: cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --data --scenario=HeavyIons -n 10 --conditions auto:run2_data_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --processName=HLTRECO --filein file:RelVal_Raw_HIon_DATA.root --fileout file:RelVal_Raw_HIon_DATA_HLT_RECO.root : FAILED - time: date Mon Jan 8 18:19:37 2018-date Mon Jan 8 18:13:01 2018 s - exit: 16640 |
|
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
Sam-Harper
force-pushed
the
EGPFClusterIsoInRECO
branch
from
6e6a25f
to
29ee74c
Compare
cmsbuild
added
code-checks-pending
and removed
code-checks-approved
comparison-notrun
tests-rejected
labels
|
thanks Andrea and Slava, I've updated the name now |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21811/3172 |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+1
|
|
@fabiocos |
|
+operations |
|
+1 |
cmsbuild
added
operations-approved
orp-approved
and removed
operations-pending
orp-pending
labels
|
merge |
PFCluster isolation is used in the HLT and is becoming more popular in E/gamma as useful isolation.
It is already stored in AOD via value maps and is embedded into pat::Electrons and pat::Photons. This change puts it directly in the reco::GsfElectron and reco::Photon for ease of use. It should be CPU and diskspace neutral (if anything, slightly less diskspace as it replaces valuemaps) as its simply changing where the isolation value is stored.
The value maps are now added to the electron,photon during the finalisation step in the same way as PFIsolations are. As such the event content is modified to drop these ValueMaps as they are unnecessary (and keyed to the tmp versions of the electrons/photons). The reducedEgamma and pat configs were updated to not to store the PF cluster isolation. However they still have a capability to read in value maps and set the PFCluster isolation. This is done incase we wish to use this release to re-miniAOD 8X or 9X samples where a customisation function would configure these modules to read the value maps. Note, I wasnt sure how to do such a customisation function so any advice here would be welcome.
The only slightly tricky part was with the OOT photons which dont have PF isolation and so dont have a finalisation step. I added one for them and they should be untouched otherwise. @kmcdermo FYI