-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10X] [L1T] [DQM] Adding HLT object matching for tag electron in EGamma #21829
Conversation
…nyTriggerFromList
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21829/2841 |
A new Pull Request was created by @kreczko (Luke Kreczko) for master. It involves the following packages: DQMOffline/L1Trigger @cmsbuild, @vazzolini, @kmaeshima, @dmitrijus, @nsmith-, @rekovic, @jfernan2, @thomreis, @vanbesien can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
Pull request #21829 was updated. @cmsbuild, @vazzolini, @kmaeshima, @dmitrijus, @nsmith-, @rekovic, @jfernan2, @thomreis, @vanbesien can you please check and sign again. |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+1 @dmitrijus please sign again. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Summary
Fixes issue https://its.cern.ch/jira/browse/CMSLITDPG-382:
Dependencies
This PR depends on #21822. Until this dependency is merged, please ignore commits 3cc1b47, 9b5d091, and 4baa92e.
The only two new commits are e4c22cf and 2da82f9.
In addition
L1TStage2CaloLayer2Offline::passesTrigger()
to L1TCommon:Looking forward to the feedback.