[10X] [L1T] [DQM] Adding HLT object matching for tag electron in EGamma #21829

kreczko · 2018-01-11T13:03:19Z

Summary

Fixes issue https://its.cern.ch/jira/browse/CMSLITDPG-382:

requiring single electron trigger
tag electron must match an HLT object of a fired trigger (within ΔR of 0.3 of the selected L1T jet).

Dependencies

This PR depends on #21822. Until this dependency is merged, please ignore commits 3cc1b47, 9b5d091, and 4baa92e.
The only two new commits are e4c22cf and 2da82f9.

In addition

moved L1TStage2CaloLayer2Offline::passesTrigger() to L1TCommon:

bool passesAnyTriggerFromList(const std::vector<unsigned int> &triggers,
                              const edm::TriggerResults &triggerResults);

adjusted configuration names for trigger variables

Looking forward to the feedback.

…nyTriggerFromList

cmsbuild · 2018-01-11T13:03:39Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-01-11T13:05:40Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21829/2841

cmsbuild · 2018-01-11T13:06:00Z

A new Pull Request was created by @kreczko (Luke Kreczko) for master.

It involves the following packages:

DQMOffline/L1Trigger

@cmsbuild, @vazzolini, @kmaeshima, @dmitrijus, @nsmith-, @rekovic, @jfernan2, @thomreis, @vanbesien can you please review it and eventually sign? Thanks.
@thomreis, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

thomreis · 2018-01-11T13:46:06Z

please test

cmsbuild · 2018-01-11T13:46:24Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25375/console Started: 2018/01/11 14:46

cmsbuild · 2018-01-11T15:50:41Z

+1
Tested at: 2da82f9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21829/25375/summary.html

cmsbuild · 2018-01-11T15:50:44Z

Comparison job queued.

cmsbuild · 2018-01-11T17:13:38Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21829/25375/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21829/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 26
DQMHistoTests: Total histograms compared: 2467710
DQMHistoTests: Total failures: 1624
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2465917
DQMHistoTests: Total skipped: 169
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 1.16 KiB( 22 files compared)
Checked 110 log files, 9 edm output root files, 26 DQM output files

cmsbuild · 2018-01-25T17:03:20Z

Pull request #21829 was updated. @cmsbuild, @vazzolini, @kmaeshima, @dmitrijus, @nsmith-, @rekovic, @jfernan2, @thomreis, @vanbesien can you please check and sign again.

thomreis · 2018-01-25T17:07:31Z

please test

cmsbuild · 2018-01-25T17:07:48Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25627/console Started: 2018/01/25 18:08

cmsbuild · 2018-01-25T22:14:24Z

+1
Tested at: be8b23f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21829/25627/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
be8b23f
0948330
2564ef0
e97b784
bfe3fba
8a3a3d3
611c78e
f1b4185
6e1333c
8f83266
e61430c
7d64c7b
c91e4fe
7e85588
c9cb7d3
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21829/25627/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21829/25627/git-merge-result

cmsbuild · 2018-01-25T22:14:26Z

Comparison job queued.

cmsbuild · 2018-01-25T23:39:49Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21829/25627/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21829/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 20 differences found in the comparisons
DQMHistoTests: Total files compared: 26
DQMHistoTests: Total histograms compared: 2463132
DQMHistoTests: Total failures: 951
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2462012
DQMHistoTests: Total skipped: 169
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.540000000023 KiB( 12 files compared)
Checked 110 log files, 9 edm output root files, 26 DQM output files

thomreis · 2018-01-26T08:24:53Z

+1

@dmitrijus please sign again.

jfernan2 · 2018-01-26T08:31:08Z

+1

cmsbuild · 2018-01-26T08:31:24Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2018-01-27T17:31:50Z

@jfernan2 this PR is claimed to be dependent on #21822, that is not signed. Could DQM experts please check that and clarify?

thomreis · 2018-01-29T07:50:09Z

#21822 is actually a subset of this PR. If this one is merged #21822 does not need to be merged anymore.

Both, #21822 and this PR needed to be signed again after a conflict was fixed. This has happened only for this PR but not for #21822.

fabiocos · 2018-01-29T10:34:21Z

+1

kreczko added 5 commits January 10, 2018 10:24

added L1TCommon for functions common across L1T DQM modules

3cc1b47

enabling HLT triggers for L1TStage2CaloLayer2Offline

9b5d091

given jet-HLTobject overlap checking function a better name

4baa92e

moved L1TStage2CaloLayer2Offline::passesTrigger to L1TCommon::passesA…

e4c22cf

…nyTriggerFromList

added HLT object matching requirement for tag electron in L1TEGamma DQM

2da82f9

cmsbuild added this to the CMSSW_10_0_X milestone Jan 11, 2018

cmsbuild added code-checks-pending comparison-pending dqm-pending l1-pending orp-pending pending-signatures tests-pending labels Jan 11, 2018

kreczko changed the title ~~Kreczko/issue/cmslitdpg 382~~ [10X] [L1T] [DQM] Adding HLT object matching for tag electron in EGamma Jan 11, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 11, 2018

cmsbuild added tests-started and removed tests-pending labels Jan 11, 2018

cmsbuild added tests-approved and removed tests-started labels Jan 11, 2018

cmsbuild added comparison-available and removed comparison-pending labels Jan 11, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 25, 2018

cmsbuild added tests-started and removed tests-pending labels Jan 25, 2018

cmsbuild added tests-approved and removed tests-started labels Jan 25, 2018

cmsbuild added comparison-available and removed comparison-pending labels Jan 25, 2018

cmsbuild added l1-approved and removed l1-pending labels Jan 26, 2018

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jan 26, 2018

cmsbuild added orp-approved and removed orp-pending labels Jan 29, 2018

cmsbuild merged commit 7f4bc8e into cms-sw:master Jan 29, 2018

thomreis mentioned this pull request Jan 29, 2018

[10X] [L1T] [DQM] Enabling trigger selection for Jets and Sums #21822

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[10X] [L1T] [DQM] Adding HLT object matching for tag electron in EGamma #21829

[10X] [L1T] [DQM] Adding HLT object matching for tag electron in EGamma #21829

kreczko commented Jan 11, 2018 •

edited

cmsbuild commented Jan 11, 2018

cmsbuild commented Jan 11, 2018

cmsbuild commented Jan 11, 2018

thomreis commented Jan 11, 2018

cmsbuild commented Jan 11, 2018 •

edited

cmsbuild commented Jan 11, 2018

cmsbuild commented Jan 11, 2018

cmsbuild commented Jan 11, 2018

cmsbuild commented Jan 25, 2018

thomreis commented Jan 25, 2018

cmsbuild commented Jan 25, 2018 •

edited

cmsbuild commented Jan 25, 2018

cmsbuild commented Jan 25, 2018

cmsbuild commented Jan 25, 2018

thomreis commented Jan 26, 2018

jfernan2 commented Jan 26, 2018

cmsbuild commented Jan 26, 2018

fabiocos commented Jan 27, 2018

thomreis commented Jan 29, 2018

fabiocos commented Jan 29, 2018

[10X] [L1T] [DQM] Adding HLT object matching for tag electron in EGamma #21829

[10X] [L1T] [DQM] Adding HLT object matching for tag electron in EGamma #21829

Conversation

kreczko commented Jan 11, 2018 • edited

Summary

Dependencies

In addition

cmsbuild commented Jan 11, 2018

cmsbuild commented Jan 11, 2018

cmsbuild commented Jan 11, 2018

thomreis commented Jan 11, 2018

cmsbuild commented Jan 11, 2018 • edited

cmsbuild commented Jan 11, 2018

cmsbuild commented Jan 11, 2018

cmsbuild commented Jan 11, 2018

cmsbuild commented Jan 25, 2018

thomreis commented Jan 25, 2018

cmsbuild commented Jan 25, 2018 • edited

cmsbuild commented Jan 25, 2018

cmsbuild commented Jan 25, 2018

cmsbuild commented Jan 25, 2018

thomreis commented Jan 26, 2018

jfernan2 commented Jan 26, 2018

cmsbuild commented Jan 26, 2018

fabiocos commented Jan 27, 2018

thomreis commented Jan 29, 2018

fabiocos commented Jan 29, 2018

kreczko commented Jan 11, 2018 •

edited

cmsbuild commented Jan 11, 2018 •

edited

cmsbuild commented Jan 25, 2018 •

edited