[10X] [L1T] [DQM] Enabling trigger selection for Jets and Sums #21822

kreczko · 2018-01-10T17:06:01Z

Fixes issue https://its.cern.ch/jira/browse/CMSLITDPG-383: enables trigger selection for jets and sums plots. All plots now require passing at least one of the configured (muon) triggers and jets further require that no HLT object is within ΔR of 0.3 of the selected L1T jet.

Since the handling of HLT objects will be useful for another issue as well as other modules, I've extracted the functionality into a separate module, L1TCommon.
In addition:

adjusted configuration names for trigger variables
extended trigger list as suggested in the Jira issue
renamed 'turn-ons' to 'efficiencies' in comments

Looking forward to the feedback.

cmsbuild · 2018-01-10T17:06:19Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-01-10T17:07:57Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21822/2827

cmsbuild · 2018-01-10T17:08:13Z

A new Pull Request was created by @kreczko (Luke Kreczko) for master.

It involves the following packages:

DQMOffline/L1Trigger

@cmsbuild, @vazzolini, @kmaeshima, @dmitrijus, @nsmith-, @rekovic, @jfernan2, @thomreis, @vanbesien can you please review it and eventually sign? Thanks.
@thomreis, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

thomreis · 2018-01-10T18:15:17Z

please test

cmsbuild · 2018-01-10T18:15:33Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25361/console Started: 2018/01/10 19:15

cmsbuild · 2018-01-10T20:03:15Z

+1
Tested at: 9b5d091
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21822/25361/summary.html

cmsbuild · 2018-01-10T20:03:17Z

Comparison job queued.

cmsbuild · 2018-01-10T20:39:23Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21822/25361/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21822/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 26
DQMHistoTests: Total histograms compared: 2775243
DQMHistoTests: Total failures: 1073
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2774001
DQMHistoTests: Total skipped: 169
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
Checked 110 log files, 9 edm output root files, 26 DQM output files

thomreis · 2018-01-11T09:20:28Z

DQMOffline/L1Trigger/src/L1TStage2CaloLayer2Offline.cc

+  double l1Phi = jet.phi();
+  const trigger::TriggerObjectCollection matchedObjects = getMatchedTriggerObjects(l1Eta, l1Phi, 0.3, hltObjects);
+
+  return matchedObjects.size() == 0;


Is this correct? I would think that if the jet passes the trigger the matchedObjects size should be != 0 and this function then returns false.

If we were using a jet trigger, yes. Since we are using Muon triggers, the L1 jet and the HLT objects should not overlap, right?
See https://its.cern.ch/jira/browse/CMSLITDPG-383?focusedCommentId=1863451&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-1863451

Ah I see, yes. I guess I was confused by the name of the function.

If you were confused, others will be as well. Let's change it now.
How about: bool L1TStage2CaloLayer2Offline::doesNotOverlapWithHLTObjects(const l1t::Jet & jet) const instead?

Sounds good to me.

thomreis · 2018-01-11T10:21:49Z

+1

cmsbuild · 2018-01-25T17:03:00Z

The code-checks are being triggered in jenkins.

kreczko · 2018-01-25T17:03:05Z

@fabiocos @thomreis Have rebased the code using the github rebase feature.
It looks OK, but tests will show.

cmsbuild · 2018-01-25T17:04:42Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21822/3044

cmsbuild · 2018-01-25T17:04:59Z

Pull request #21822 was updated. @cmsbuild, @vazzolini, @kmaeshima, @dmitrijus, @nsmith-, @rekovic, @jfernan2, @thomreis, @vanbesien can you please check and sign again.

thomreis · 2018-01-25T17:07:49Z

please test

cmsbuild · 2018-01-25T17:08:09Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25628/console Started: 2018/01/25 18:11

cmsbuild · 2018-01-25T21:52:56Z

+1
Tested at: be29d8f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21822/25628/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
be29d8f
0948330
2564ef0
e97b784
bfe3fba
8a3a3d3
611c78e
f1b4185
6e1333c
8f83266
e61430c
7d64c7b
c91e4fe
7e85588
c9cb7d3
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21822/25628/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21822/25628/git-merge-result

cmsbuild · 2018-01-25T21:52:59Z

Comparison job queued.

cmsbuild · 2018-01-25T23:12:46Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21822/25628/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21822/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 20 differences found in the comparisons
DQMHistoTests: Total files compared: 26
DQMHistoTests: Total histograms compared: 2463132
DQMHistoTests: Total failures: 951
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2462012
DQMHistoTests: Total skipped: 169
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.550000000032 KiB( 12 files compared)
Checked 110 log files, 9 edm output root files, 26 DQM output files

thomreis · 2018-01-26T08:25:14Z

+1

@dmitrijus please sign again.

thomreis · 2018-01-29T10:38:39Z

@kreczko please check if these conflicts need to be resolved or if all is well now that #21829 has been merged.

kreczko · 2018-01-29T10:53:36Z

@thomreis since #21829 was merged before this one, there is no longer a reason to merge this.

kreczko added 2 commits January 10, 2018 10:24

added L1TCommon for functions common across L1T DQM modules

3cc1b47

enabling HLT triggers for L1TStage2CaloLayer2Offline

9b5d091

cmsbuild added this to the CMSSW_10_0_X milestone Jan 10, 2018

cmsbuild added code-checks-pending comparison-pending dqm-pending l1-pending orp-pending pending-signatures tests-pending labels Jan 10, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 10, 2018

cmsbuild added tests-started and removed tests-pending labels Jan 10, 2018

cmsbuild added tests-approved and removed tests-started labels Jan 10, 2018

cmsbuild added comparison-available and removed comparison-pending labels Jan 10, 2018

thomreis reviewed Jan 11, 2018

View reviewed changes

cmsbuild added l1-approved and removed l1-pending labels Jan 11, 2018

cmsbuild added code-checks-pending comparison-pending dqm-pending l1-pending pending-signatures tests-pending and removed tests-approved labels Jan 25, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 25, 2018

cmsbuild added tests-started and removed tests-pending labels Jan 25, 2018

cmsbuild added tests-approved and removed tests-started labels Jan 25, 2018

cmsbuild added comparison-available and removed comparison-pending labels Jan 25, 2018

cmsbuild added l1-approved and removed l1-pending labels Jan 26, 2018

kreczko closed this Jan 29, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[10X] [L1T] [DQM] Enabling trigger selection for Jets and Sums #21822

[10X] [L1T] [DQM] Enabling trigger selection for Jets and Sums #21822

kreczko commented Jan 10, 2018

cmsbuild commented Jan 10, 2018

cmsbuild commented Jan 10, 2018

cmsbuild commented Jan 10, 2018

thomreis commented Jan 10, 2018

cmsbuild commented Jan 10, 2018 •

edited

Loading

cmsbuild commented Jan 10, 2018

cmsbuild commented Jan 10, 2018

cmsbuild commented Jan 10, 2018

thomreis Jan 11, 2018

kreczko Jan 11, 2018 •

edited

Loading

thomreis Jan 11, 2018

kreczko Jan 11, 2018

thomreis Jan 11, 2018

thomreis commented Jan 11, 2018

cmsbuild commented Jan 25, 2018

kreczko commented Jan 25, 2018

cmsbuild commented Jan 25, 2018

cmsbuild commented Jan 25, 2018

thomreis commented Jan 25, 2018

cmsbuild commented Jan 25, 2018 •

edited

Loading

cmsbuild commented Jan 25, 2018

cmsbuild commented Jan 25, 2018

cmsbuild commented Jan 25, 2018

thomreis commented Jan 26, 2018

thomreis commented Jan 29, 2018

kreczko commented Jan 29, 2018

[10X] [L1T] [DQM] Enabling trigger selection for Jets and Sums #21822

[10X] [L1T] [DQM] Enabling trigger selection for Jets and Sums #21822

Conversation

kreczko commented Jan 10, 2018

cmsbuild commented Jan 10, 2018

cmsbuild commented Jan 10, 2018

cmsbuild commented Jan 10, 2018

thomreis commented Jan 10, 2018

cmsbuild commented Jan 10, 2018 • edited Loading

cmsbuild commented Jan 10, 2018

cmsbuild commented Jan 10, 2018

cmsbuild commented Jan 10, 2018

thomreis Jan 11, 2018

Choose a reason for hiding this comment

kreczko Jan 11, 2018 • edited Loading

Choose a reason for hiding this comment

thomreis Jan 11, 2018

Choose a reason for hiding this comment

kreczko Jan 11, 2018

Choose a reason for hiding this comment

thomreis Jan 11, 2018

Choose a reason for hiding this comment

thomreis commented Jan 11, 2018

cmsbuild commented Jan 25, 2018

kreczko commented Jan 25, 2018

cmsbuild commented Jan 25, 2018

cmsbuild commented Jan 25, 2018

thomreis commented Jan 25, 2018

cmsbuild commented Jan 25, 2018 • edited Loading

cmsbuild commented Jan 25, 2018

cmsbuild commented Jan 25, 2018

cmsbuild commented Jan 25, 2018

thomreis commented Jan 26, 2018

thomreis commented Jan 29, 2018

kreczko commented Jan 29, 2018

cmsbuild commented Jan 10, 2018 •

edited

Loading

kreczko Jan 11, 2018 •

edited

Loading

cmsbuild commented Jan 25, 2018 •

edited

Loading