Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restoring premix library for UP15 workflows #21831

Merged
merged 1 commit into from Jan 12, 2018

Conversation

fabozzi
Copy link
Contributor

@fabozzi fabozzi commented Jan 11, 2018

Fixing failure in recent IBs for premixing UP15 workflows after merging of #21819 (due to wrong input premix PU library call)

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabozzi for master.

It involves the following packages:

Configuration/PyReleaseValidation

@cmsbuild, @GurpreetSinghChahal, @prebello, @kpedro88, @fabozzi can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @ebrondol, @ghellwig, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabozzi
Copy link
Contributor Author

fabozzi commented Jan 11, 2018

please test workflow 250200

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 11, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25390/console Started: 2018/01/11 18:25

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21831/25390/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21831/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21831/250200.0_ZEE_13+ZEE_13+DIGIPRMXUP15_PU25+RECOPRMXUP15_PU25+HARVESTUP15_PU25

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2467710
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2467540
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.959999999977 KiB( 22 files compared)
  • Checked 110 log files, 9 edm output root files, 26 DQM output files

@fabozzi
Copy link
Contributor Author

fabozzi commented Jan 12, 2018

+1

@fabiocos
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

@kpedro88 could you please approve it asap? It will avoid IBs crashes.

@fabiocos
Copy link
Contributor

merged

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit e43f303 into cms-sw:master Jan 12, 2018
@kpedro88
Copy link
Contributor

@fabiocos in the future, feel free to merge general relval fixes/updates without my signature; I'm just on this package for changes to the upgrade workflows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants