Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit test failure. #2184

Merged

Conversation

wddgit
Copy link
Contributor

@wddgit wddgit commented Jan 27, 2014

In test diff ignore text some class is printing to std::out in its constructor.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_7_1_THREADED_X.

Fix unit test failure.

It involves the following packages:

IOMC/RandomEngine

@cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@ktf
Copy link
Contributor

ktf commented Jan 27, 2014

Why threaded only?

@wddgit
Copy link
Contributor Author

wddgit commented Jan 27, 2014

The fix is only on the threaded branch, because the failing test does not exist on the 7_1_X branch. It is an explicit test of multiple streams. It was created with the multithreaded random number service which was only merged into the threaded branch so far. We did not merge it into the 7_1_X branch because it breaks some RelVals because there is still code that uses the old interface. When the old interface is used with the new multithreaded service, replay is broken and that is what is causing RelVals to fail.

A separate issue. I do not understand why the class causing the error is ever constructed because nothing in the test uses it or references it as far as I know. Maybe something in the dictionary loading? I don't know.

@ktf
Copy link
Contributor

ktf commented Jan 27, 2014

Ok, thanks for the explanation. I'll merge your stuff. We should probably have a campaign to clean up std::cout as well... :-/

ktf added a commit that referenced this pull request Jan 27, 2014
Misc fixes -- Fix unit test failure in IOMCRandomEngine
@ktf ktf merged commit 1d1dbf2 into cms-sw:CMSSW_7_1_THREADED_X Jan 27, 2014
@Dr15Jones
Copy link
Contributor

The threaded build has to load all known dictionaries into the job to avoid problems with ROOT.

@wddgit wddgit deleted the fixIOMCRandomEngineIBFailure branch April 7, 2014 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants