Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New thresholds for gathering and seeding in PF in EE, and deactivation of SR@PF #21846

Merged
merged 3 commits into from Jan 18, 2018
Merged

New thresholds for gathering and seeding in PF in EE, and deactivation of SR@PF #21846

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6678cc2
new thresholds for gathering and seeding in PF in EE, and deactivatio…
amassiro Jan 12, 2018
e4ad8c7
rechit thresholds configuration eta dependent, and 2017 seeding and g…
amassiro Jan 16, 2018
f4f6008
addition of the explanation of commented lines
amassiro Jan 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions RecoParticleFlow/PFClusterProducer/python/particleFlowClusterECALUncorrected_cfi.py
View file
Open in desktop
Expand Up @@ -38,8 +38,8 @@
algoName = cms.string("LocalMaximumSeedFinder"),
thresholdsByDetector = cms.VPSet(
cms.PSet( detector = cms.string("ECAL_ENDCAP"),
seedingThreshold = cms.double(0.6),
seedingThresholdPt = cms.double(0.15)
seedingThreshold = cms.double(0.50),
seedingThresholdPt = cms.double(0.50)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have any Z->ee plots to show that this increase is OK?
I can imagine that shower or brem cases can degrade quite a bit.
@Sam-Harper what do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we discussed this at length in the ECAL+E/gamma meeting with jetMET. JetMET need these thresholds to control the MET. For E/gamma, they are likely not ideal (although the results could be surprising with PU contributions), for the reasons you say. The plan is to check if it really causes a major (and it has to be major) problem for E/gamma although given the timeline, they may not complete in time for pre4 in which case we'll just go ahead.

If 10_0_0 has slightly worse performance in the endcap at low pt, its no big deal, we'll fix it next release. The samples we will need in 10_0_0 will be for energy regressions and we save the raw for those so in a pinch we can always re-reco them ourselves with new settings.

),
cms.PSet( detector = cms.string("ECAL_BARREL"),
seedingThreshold = cms.double(0.23),
Expand All @@ -58,8 +58,8 @@
gatheringThresholdPt = cms.double(0.0)
),
cms.PSet( detector = cms.string("ECAL_ENDCAP"),
gatheringThreshold = cms.double(0.3),
gatheringThresholdPt = cms.double(0.0)
gatheringThreshold = cms.double(0.50),
gatheringThresholdPt = cms.double(0.50)
)
),
useCornerCells = cms.bool(True)
Expand Down
8 changes: 4 additions & 4 deletions RecoParticleFlow/PFClusterProducer/python/particleFlowRecHitECAL_cfi.py
View file
Open in desktop
Expand Up @@ -19,8 +19,8 @@
srFlags = cms.InputTag("ecalDigis"),
qualityTests = cms.VPSet(
cms.PSet(
name = cms.string("PFRecHitQTestECALMultiThreshold"),
thresholds = particle_flow_zero_suppression_ECAL.thresholds
name = cms.string("PFRecHitQTestThreshold"),
threshold = cms.double(0.08)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize that we have an issue in the barrel as well.
In case I missed something, please point me to some plots that quantify degradation in the barrel.

),
cms.PSet(
name = cms.string("PFRecHitQTestECAL"),
Expand All @@ -37,8 +37,8 @@
srFlags = cms.InputTag("ecalDigis"),
qualityTests = cms.VPSet(
cms.PSet(
name = cms.string("PFRecHitQTestECALMultiThreshold"),
thresholds = particle_flow_zero_suppression_ECAL.thresholds
name = cms.string("PFRecHitQTestThreshold"),
threshold = cms.double(0.3)
),
cms.PSet(
name = cms.string("PFRecHitQTestECAL"),
Expand Down