Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New thresholds for gathering and seeding in PF in EE, and deactivation of SR@PF #21846

Merged
merged 3 commits into from Jan 18, 2018
Merged

New thresholds for gathering and seeding in PF in EE, and deactivation of SR@PF #21846

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6678cc2
new thresholds for gathering and seeding in PF in EE, and deactivatio…
amassiro Jan 12, 2018
e4ad8c7
rechit thresholds configuration eta dependent, and 2017 seeding and g…
amassiro Jan 16, 2018
f4f6008
addition of the explanation of commented lines
amassiro Jan 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion RecoParticleFlow/PFClusterProducer/python/particleFlowClusterECALUncorrected_cfi.py
View file
Open in desktop
Expand Up @@ -38,7 +38,7 @@
algoName = cms.string("LocalMaximumSeedFinder"),
thresholdsByDetector = cms.VPSet(
cms.PSet( detector = cms.string("ECAL_ENDCAP"),
seedingThreshold = cms.double(0.6),
seedingThreshold = cms.double(0.60),
seedingThresholdPt = cms.double(0.15)
),
cms.PSet( detector = cms.string("ECAL_BARREL"),
Expand Down
4 changes: 2 additions & 2 deletions RecoParticleFlow/PFClusterProducer/python/particleFlowRecHitECAL_cfi.py
View file
Open in desktop
Expand Up @@ -16,7 +16,7 @@
cms.PSet(
name = cms.string("PFEBRecHitCreator"),
src = cms.InputTag("ecalRecHit","EcalRecHitsEB"),
srFlags = cms.InputTag("ecalDigis"),
srFlags = cms.InputTag(""),
qualityTests = cms.VPSet(
cms.PSet(
name = cms.string("PFRecHitQTestECALMultiThreshold"),
Expand All @@ -34,7 +34,7 @@
cms.PSet(
name = cms.string("PFEERecHitCreator"),
src = cms.InputTag("ecalRecHit","EcalRecHitsEE"),
srFlags = cms.InputTag("ecalDigis"),
srFlags = cms.InputTag(""),
qualityTests = cms.VPSet(
cms.PSet(
name = cms.string("PFRecHitQTestECALMultiThreshold"),
Expand Down
8 changes: 4 additions & 4 deletions RecoParticleFlow/PFClusterProducer/python/particleFlowZeroSuppressionECAL_cff.py
View file
Open in desktop
Expand Up @@ -23,8 +23,8 @@
)
)

from Configuration.Eras.Modifier_run2_ECAL_2017_cff import run2_ECAL_2017
run2_ECAL_2017.toReplaceWith(particle_flow_zero_suppression_ECAL, _particle_flow_zero_suppression_ECAL_2017)
#from Configuration.Eras.Modifier_run2_ECAL_2017_cff import run2_ECAL_2017
#run2_ECAL_2017.toReplaceWith(particle_flow_zero_suppression_ECAL, _particle_flow_zero_suppression_ECAL_2017)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this commented out code needed?
Please remove or add comments inline in the code why the commented out block is relevant


from Configuration.Eras.Modifier_phase2_ecal_cff import phase2_ecal
phase2_ecal.toReplaceWith(particle_flow_zero_suppression_ECAL, _particle_flow_zero_suppression_ECAL_2017)
#from Configuration.Eras.Modifier_phase2_ecal_cff import phase2_ecal
#phase2_ecal.toReplaceWith(particle_flow_zero_suppression_ECAL, _particle_flow_zero_suppression_ECAL_2017)