Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New GT][2018 realistic and cosmic realistic] 2018 GEM,HCAL geom + ECAL thresholds for 2018 #21854

Merged
merged 2 commits into from Jan 17, 2018

Conversation

lpernie
Copy link
Contributor

@lpernie lpernie commented Jan 15, 2018

CHANGES:
2018 realistic: 100X_upgrade2018_realistic_v6
Diff with old GT:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/100X_upgrade2018_realistic_v6/100X_upgrade2018_realistic_v4
-> 2018 GEM and HCAL geom. + New ECAL thresholds

2018 realistic cosmics: 100X_upgrade2018cosmics_realistic_deco_v5
Diff with old GT:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/100X_upgrade2018cosmics_realistic_deco_v5/100X_upgrade2018cosmics_realistic_deco_v3
-> 2018 GEM and HCAL geom. + New ECAL thresholds + HCAL Channel Quality, LUTCorrs. RespCorrs, ZSThresholds, QIEData

2018 ideal: 100X_upgrade2018_design_IdealBS_v4
Diff with old GT:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/100X_upgrade2018_design_IdealBS_v4/100X_upgrade2018_design_IdealBS_v3
-> 2018 GEM and HCAL geom. + HCAL Channel Quality, LUTCorrs. RespCorrs, ZSThresholds, QIEData
NOTES:
. The new conditions will be signed off during the PPD meeting on Jan 18

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@lpernie
Copy link
Contributor Author

lpernie commented Jan 15, 2018

please test

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 15, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25455/console Started: 2018/01/15 18:14

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lpernie (Luca Pernie) for master.

It involves the following packages:

Configuration/AlCa

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @ghellwig, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21854/25455/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21854/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1530 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2467599
  • DQMHistoTests: Total failures: 3662
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2463768
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.899999999987 KiB( 22 files compared)
  • Checked 110 log files, 9 edm output root files, 26 DQM output files

@lpernie
Copy link
Contributor Author

lpernie commented Jan 16, 2018

In the Unit tests I see:
config/SCRAM/GMake/Makefile.rules:2081: recipe for target 'unittests_runTheWhiteRabbit' failed
gmake: *** [unittests_runTheWhiteRabbit] Terminated

Maybe a glitch? I will submit tests again

@lpernie
Copy link
Contributor Author

lpernie commented Jan 16, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 16, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25482/console Started: 2018/01/16 20:20

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21854/25482/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21854/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1535 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2468799
  • DQMHistoTests: Total failures: 5032
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2463598
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.49999999988 KiB( 22 files compared)
  • Checked 110 log files, 9 edm output root files, 26 DQM output files

@lpernie
Copy link
Contributor Author

lpernie commented Jan 16, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@lpernie (and @deguio @crovelli ) Is there any dependency between this tag and the pending PRs for HCAL and ECAL? At latest ORP I understood that the affected geometry will be the reco one (so GEN-SIM will be unaffected), is it correct? And I see other parameters affected (e.g. ECAL thresholds...)

@crovelli
Copy link
Contributor

crovelli commented Jan 17, 2018 via email

@deguio
Copy link
Contributor

deguio commented Jan 17, 2018

Hi @fabiocos
correct. for hcal the affected geometry will be the reco one. this GT makes possible to run the collapsed 2018 scenario using #21842

@abdoulline
Copy link

abdoulline commented Jan 17, 2018 via email

@deguio
Copy link
Contributor

deguio commented Jan 17, 2018

yes. and the collapsed 2018 validation with pre4

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a3990fe into cms-sw:master Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants