Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further updates to the FastTimerService for 10.0.x #21865

Merged
merged 5 commits into from Jan 17, 2018

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jan 16, 2018

Follow up on #21738 .

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 16, 2018

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 16, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25474/console Started: 2018/01/16 18:12

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

HLTrigger/Timer

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 16, 2018 via email

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21865/25474/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21865/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2468799
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2468629
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.47999999992 KiB( 22 files compared)
  • Checked 110 log files, 9 edm output root files, 26 DQM output files

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 85ab2e1 into cms-sw:master Jan 17, 2018
@fabiocos
Copy link
Contributor

@fwyzard @Martin-Grunewald a minor remark: during the compilation you get

Subsystem Calibration built
gmake[1]: Entering directory '/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-15-2300'
tmp/slc6_amd64_gcc630/MakeData/DirCache.mk:30: No such file exists: src/HLTrigger/Timer/test/chrono/test/chrono.cc. Please fix src/HLTrigger/Timer/test/BuildFile.
tmp/slc6_amd64_gcc630/MakeData/DirCache.mk:30: No such file exists: src/HLTrigger/Timer/test/chrono/src/.cc. Please fix src/HLTrigger/Timer/test/BuildFile.
tmp/slc6_amd64_gcc630/MakeData/DirCache.mk:30: No such file exists: src/HLTrigger/Timer/test/chrono/src/native/
.cc. Please fix src/HLTrigger/Timer/test/BuildFile.

as those files are no more there

@Martin-Grunewald
Copy link
Contributor

Fixed in #21869

@fwyzard fwyzard deleted the FastTimerService_updates_100x branch January 17, 2018 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants