New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10_1_X] SiStrip Gains conditions DB manipulation tools #21870
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21870/2916 |
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: CondCore/SiStripPlugins @ggovi, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21870/2921 |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Greetings,
the aim of this PR is to introduce two plugins to manipulate SiStrip gain condition objects.
SiStripApvGainRescaler
is designed to be used to rescale the values of the SiStrip G2 (a.k.a. particle) gains whenever there is an update of the SiStrip G1 (a.k.a. tickmark height) gains, before the cluster statistics for achieving a G2 measurement in-situ is available, according to the simple formula G2_new = (G1_old*G2_old)/G1_new.SiStripChannelGainFromDBMiscalibrator
is designed to create mis-calibrations on top of an existing payload by smearing or setting an off scale, hierarchically, for the gain values up to the layer (wheel) levelI profit of this PR to fix a small inconsistency in the axis labeling of one of the payload inspector plots found when commissioning the tools.