CalibMuon/CSCCalibration: Change return type of ESProducer::produce methods to unique_ptr or shared_ptr. #21910
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21910/2964 |
| @@ -26,7 +26,7 @@ class CSCFakeCrosstalkConditions: public edm::ESProducer, public edm::EventSetup | |||
|
|
|||
| void prefillCrosstalk(); | |||
|
|
|||
| typedef const CSCcrosstalk * ReturnType; | |||
| typedef std::unique_ptr<CSCcrosstalk>ReturnType; | |||
|
Please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @gartung (Patrick Gartung) for master. It involves the following packages: CalibMuon/CSCCalibration @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
cmsbuild
added
code-checks-pending
tests-pending
and removed
code-checks-approved
tests-started
labels
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21910/2965 |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21910/3179 |
|
please test |
|
+1 |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+1 |
In preparation for a move to multi IOV events in parallel, the return type of ESProducer::produce mehtods must be changed to unique_ptr or shared_ptr. These ptrs should not refer to member data. Rather they should refer to new(copied) objects.