Displace-tracking development in heavy ion tracking #21930

KongTu · 2018-01-23T19:08:48Z

This displace-tracking development in heavy ion reconstruction is to find (like CMS standard pp tracking) the large impact parameter tracks for strange particles or heavy-flavor particles reconstruction.

This PR contains the following items:

Added the configurations for 3 iterations: "hiMixedTripletStep", "hiPixelLessStep", "hiTobTecStep". Modified on top of the default tracking algorithm from standard pp tracking.
The TrackingRegion parameters are modified to reduce the timing on these 3 iterations above, e.g., the minPt and originHalfLength.
A "scaling" function has been implemented (in this file GlobalTrackingRegionWithVerticesProducer.h), where according to the number of pixel clusters (mostly for more central heavy ion events), the TrackingRegion parameters, e.g., minPt, originRadius, originHalfLength, are scaled up (pt) or down (originRaidu or originHalfLength) linearly above a certain threshold (for example Npix=20000). Therefore the timing can be greatly reduced towards very central events.

Supporting presentations:

Performance plots on efficiency, fake rate, secondary rate (where it matters), https://indico.cern.ch/event/699094/contributions/2867255/attachments/1587914/2512006/Tracking_PR_preparation.pdf
Note that the comparison here is to compare "default" values from the standard pp tracking vs the modified values in the TrackingRegion parameters of the added iterations.
Study of V0s in terms of added 3 iterations:
https://indico.cern.ch/event/638128/contributions/2585615/attachments/1460150/2255756/Tracking_6_90X.pdf
https://indico.cern.ch/event/646309/contributions/2625076/attachments/1475706/2285788/Tracking_7_90X.pdf
Timing study as a function of Npix, https://indico.cern.ch/event/699094/contributions/2867255/attachments/1587914/2511992/Timing_displacedTracking_Jan24.pdf

@abaty @mandrenguyen

…with cms-merge-topic

cmsbuild · 2018-01-23T19:09:07Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-01-23T19:10:52Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21930/2998

cmsbuild · 2018-01-23T19:11:11Z

A new Pull Request was created by @KongTu (KongTu) for master.

It involves the following packages:

RecoHI/HiTracking
RecoTracker/TkTrackingRegions

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @felicepantaleo, @GiacomoSguazzoni, @jazzitup, @VinInn, @echapon, @mschrode, @yenjie, @rovere, @kurtejung, @gpetruc, @ebrondol, @mandrenguyen, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

slava77 · 2018-01-23T19:17:25Z

@KongTu

Timing study as a function of Npix, https://indico.cern.ch/event/699094/contributions/2867255/attachments/1587914/2511992/Timing_displacedTracking_Jan24.pdf

the plot has "blue" (this PR) both above and below the baseline.
Please clarify what is happening in the lower bins.

slava77 · 2018-01-23T19:17:33Z

@cmsbuild please test

cmsbuild · 2018-01-23T19:17:40Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25581/console Started: 2018/01/23 20:18

abaty · 2018-01-23T19:35:53Z

@slava77 @KongTu

the plot has "blue" (this PR) both above and below the baseline.
Please clarify what is happening in the lower bins.

Each point here represents the processing time of a single event, so I suspect the difference seen in the lower bins is just a fluctuation in the processing time. The code here does not 'remove' any features for central events to make them run faster; it only adds tracking iterations for more peripheral events.

cmsbuild · 2018-01-23T21:02:16Z

+1
Tested at: 8113960
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21930/25581/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
e7733ec
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21930/25581/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21930/25581/git-merge-result

cmsbuild · 2018-01-23T21:02:19Z

Comparison job queued.

cmsbuild · 2018-02-15T15:36:05Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-02-15T15:39:28Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21930/3384

cmsbuild · 2018-02-15T15:39:50Z

Pull request #21930 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

slava77 · 2018-02-15T15:50:09Z

@cmsbuild please test

@abaty
thank you for the quick updates

cmsbuild · 2018-02-15T15:50:27Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26100/console Started: 2018/02/15 16:52

cmsbuild · 2018-02-15T18:24:57Z

+1
Tested at: 1b849c7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21930/26100/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
8b43db8
1563893
bb4fa82
e7733ec
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21930/26100/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21930/26100/git-merge-result

cmsbuild · 2018-02-15T18:25:00Z

Comparison job queued.

slava77 · 2018-02-15T19:04:32Z

RecoHI/HiTracking/python/hiMixedTripletStep_cff.py

-
+mixedTripletStepSeedLayersA.layerList = cms.vstring('BPix1+BPix2+BPix3', 'BPix1+BPix2+FPix1_pos', 'BPix1+BPix2+FPix1_neg', 
+                                        'BPix1+FPix1_pos+FPix2_pos', 'BPix1+FPix1_neg+FPix2_neg', 
+                                        'BPix2+FPix1_pos+FPix2_pos', 'BPix2+FPix1_neg+FPix2_neg')


the modifications made here actually propagate to hiRegitMuMixedTripletStepSeedLayersA.
I'm not sure that this is desired.

Based on the phase-0 configuration (wf 140.53) this is the only place with such dependency.

An easy fix is to set the layerList in hiRegitMuMixedTripletStepSeedLayersA explicitly.
OTOH, perhaps it's OK to have a more covering layer list for hiRegitMuMixedTripletStepSeedLayersA

@KongTu @abaty please check

@slava77 I think having the extra layers in the list for the Regit step is fine; these steps tend to run quite quickly and produce a fairly small number of tracks. It is probably best for consistency to keep these two iterations using the same layer list.

cmsbuild · 2018-02-15T20:11:20Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21930/26100/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 25 differences found in the comparisons
DQMHistoTests: Total files compared: 27
DQMHistoTests: Total histograms compared: 2465360
DQMHistoTests: Total failures: 29
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2465162
DQMHistoTests: Total skipped: 169
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 1.07999999987 KiB( 22 files compared)
Checked 111 log files, 9 edm output root files, 27 DQM output files

slava77 · 2018-02-15T20:52:50Z

Based on wf 150.0 I see that

CPU time in reco increases by about 25% (from 11.4 to 14.2 s/ev)
- most of the increase is in the new modules +2.7 s/ev
- the rest is about 0.2 s/ev and it shows up in related modules (e.g. hiGeneralTracks or hiMuons1stStep, and particleFlowBlock);
RSS peak (based on MemoryCheck) goes up by about 100 MB. This looks ~OK and should likely be smaller on a job writing AOD

Physics performance roughly looks as expected:

there are about 20% more tracks
CS jets look somewhat similar
the efficiency increases similarly for HP and all tracks

- fake rates are up for inclusive tracks (some cleanup is likely needed in a followup), while for HP tracks the fake rate is only about 10-20% (fractionally) higher

- the duplicate rate is up significantly (is merging good enough or needs some reconfiguration eventually?)

I'm ready to signoff pending the resolution of the hiRegitMuMixedTripletStepSeedLayersA configuration

slava77 · 2018-02-16T13:22:09Z

+1

for #21930 1b849c7

the implementation is in line with the description and the follow up code review. The change targets phase-1 tracking setup.
- One side-effect of the refactored implementation is a change in hiRegitMuMixedTripletStepSeedLayersA, which was confirmed as OK Displace-tracking development in heavy ion tracking #21930 (comment)
jenkins tests pass and comparisons show only tiny changes in the HI workflow 140.53 which are related just to the side-effect in hiRegitMuMixedTripletStepSeedLayersA
results of higher stat tests are summarized in Displace-tracking development in heavy ion tracking #21930 (comment)

cmsbuild · 2018-02-16T13:22:27Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2018-02-16T18:00:32Z

+1

abaty and others added 9 commits November 24, 2017 16:03

adding in detached steps in python

c4ea83f

added tracking region scaling for HI collisions

124e7fc

added InputTag parameter to PSet

2ae79f1

added missing comma

0b9982a

fixed typo

35ef49b

some bugfixed

043f28a

ready for pre-PR on displaced-tracking

632f9d2

Merged displacedHITracking_10_0_0_pre1 from repository cmsHiTracking …

e7733ec

…with cms-merge-topic

some cleanup

8113960

cmsbuild added this to the CMSSW_10_0_X milestone Jan 23, 2018

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jan 23, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 23, 2018

cmsbuild added tests-started and removed tests-pending labels Jan 23, 2018

cmsbuild removed the tests-started label Jan 23, 2018

cmsbuild added the tests-pending label Feb 15, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 15, 2018

cmsbuild added tests-started and removed tests-pending labels Feb 15, 2018

cmsbuild added tests-approved and removed tests-started labels Feb 15, 2018

slava77 reviewed Feb 15, 2018

View reviewed changes

cmsbuild added comparison-available and removed comparison-pending labels Feb 15, 2018

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Feb 16, 2018

cmsbuild added orp-approved and removed orp-pending labels Feb 16, 2018

cmsbuild merged commit f97ecf7 into cms-sw:master Feb 16, 2018

abaty mentioned this pull request Jun 6, 2018

Modifications to tracking in pp_on_AA_2018 era to improve timing #23510

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Displace-tracking development in heavy ion tracking #21930

Displace-tracking development in heavy ion tracking #21930

KongTu commented Jan 23, 2018

cmsbuild commented Jan 23, 2018

cmsbuild commented Jan 23, 2018

cmsbuild commented Jan 23, 2018

slava77 commented Jan 23, 2018

slava77 commented Jan 23, 2018

cmsbuild commented Jan 23, 2018 •

edited

abaty commented Jan 23, 2018

cmsbuild commented Jan 23, 2018

cmsbuild commented Jan 23, 2018

cmsbuild commented Feb 15, 2018

cmsbuild commented Feb 15, 2018

cmsbuild commented Feb 15, 2018

slava77 commented Feb 15, 2018

cmsbuild commented Feb 15, 2018 •

edited

cmsbuild commented Feb 15, 2018

cmsbuild commented Feb 15, 2018

slava77 Feb 15, 2018

abaty Feb 16, 2018

cmsbuild commented Feb 15, 2018

slava77 commented Feb 15, 2018

slava77 commented Feb 16, 2018

cmsbuild commented Feb 16, 2018

fabiocos commented Feb 16, 2018

Displace-tracking development in heavy ion tracking #21930

Displace-tracking development in heavy ion tracking #21930

Conversation

KongTu commented Jan 23, 2018

cmsbuild commented Jan 23, 2018

cmsbuild commented Jan 23, 2018

cmsbuild commented Jan 23, 2018

slava77 commented Jan 23, 2018

slava77 commented Jan 23, 2018

cmsbuild commented Jan 23, 2018 • edited

abaty commented Jan 23, 2018

cmsbuild commented Jan 23, 2018

cmsbuild commented Jan 23, 2018

cmsbuild commented Feb 15, 2018

cmsbuild commented Feb 15, 2018

cmsbuild commented Feb 15, 2018

slava77 commented Feb 15, 2018

cmsbuild commented Feb 15, 2018 • edited

cmsbuild commented Feb 15, 2018

cmsbuild commented Feb 15, 2018

slava77 Feb 15, 2018

Choose a reason for hiding this comment

abaty Feb 16, 2018

Choose a reason for hiding this comment

cmsbuild commented Feb 15, 2018

slava77 commented Feb 15, 2018

slava77 commented Feb 16, 2018

cmsbuild commented Feb 16, 2018

fabiocos commented Feb 16, 2018

cmsbuild commented Jan 23, 2018 •

edited

cmsbuild commented Feb 15, 2018 •

edited