-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post Muon TDR ME0 geometry cleanup #21936
Post Muon TDR ME0 geometry cleanup #21936
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21936/3006 |
A new Pull Request was created by @dildick (Sven Dildick) for master. It involves the following packages: Geometry/GEMGeometry @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+1 |
Pull request #21936 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again. |
@kpedro88 I think you are you right. The changes in |
@dildick okay, thanks |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
@ianna Could you check again please? |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Several updates included in this PR:
ME0GeometryBuilderFromDDD
(not used for Muon TDR studies) was deletedME0GeometryBuilderFromDDD10EtaPart
(used for Muon TDR studies) was renamed toME0GeometryBuilderFromDDD
The default ME0 geometry has 8 eta partitions. This work is in preparation to start ME0Trigger studies on real digis.
Attached is the output of the geometry tester showing in detail the layout of the system.
ME0testOutput.txt
@jshlee @archiesharma @mmaggi