Post Muon TDR ME0 geometry cleanup

[dildick]

Several updates included in this PR:

• old ME0GeometryBuilderFromDDD (not used for Muon TDR studies) was deleted
• ME0GeometryBuilderFromDDD10EtaPart (used for Muon TDR studies) was renamed to ME0GeometryBuilderFromDDD
• nPads for ME0 now set to be 192 as in Muon Upgrade TDR

The default ME0 geometry has 8 eta partitions. This work is in preparation to start ME0Trigger studies on real digis.

Attached is the output of the geometry tester showing in detail the layout of the system.
ME0testOutput.txt

@jshlee @archiesharma @mmaggi

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21936/3006

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

Geometry/GEMGeometry
Geometry/GEMGeometryBuilder
Geometry/MuonCommonData
Geometry/MuonNumbering

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@ghellwig, @ptcox this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25590/console Started: 2018/01/24 02:44

[cmsbuild]

+1
Tested at: 5c4a9be
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21936/25590/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21936/25590/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21936/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2467599
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2467429
• DQMHistoTests: Total skipped: 169
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.66000000012 KiB( 22 files compared)
• Checked 110 log files, 9 edm output root files, 26 DQM output files

[dildick]

@ianna @kpedro88 Could you check it please?

[ianna]

+1

[cmsbuild]

Pull request #21936 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again.

[dildick]

@kpedro88 I think you are you right. The changes in muonNumbering.xml would also affect the D17 geometry. I'd rather see nrolls_me0 (with value 10) disappear because it contradicts the actual number of rolls (8). But it seems that, except for debugging in ME0NumberingScheme, it is not used. So for the time being we can leave it in the muon numbering xml file

[kpedro88]

@dildick okay, thanks

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25911/console Started: 2018/02/05 22:32

[cmsbuild]

+1
Tested at: 0492908
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21936/25911/summary.html

[cmsbuild]

Comparison job queued.

[dildick]

@ianna Could you check again please?

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21936/25911/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21936/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2465763
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2465593
• DQMHistoTests: Total skipped: 169
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.11000000008 KiB( 22 files compared)
• Checked 110 log files, 9 edm output root files, 26 DQM output files

[kpedro88]

+1

[ianna]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1