Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compression level in NANOAOD #21953

Merged
merged 1 commit into from Feb 1, 2018
Merged

Conversation

arizzi
Copy link
Contributor

@arizzi arizzi commented Jan 25, 2018

same as #21874

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @arizzi for CMSSW_10_0_X.

It involves the following packages:

Configuration/DataProcessing

@cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor

fabiocos commented Feb 1, 2018

+operations

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25839/console Started: 2018/02/01 15:20

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2018

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_0_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_10_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Feb 1, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2018

Comparison job queued.

@cmsbuild cmsbuild merged commit fe05df7 into cms-sw:CMSSW_10_0_X Feb 1, 2018
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21953/25839/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21953/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2468773
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2468603
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.04000000013 KiB( 22 files compared)
  • Checked 110 log files, 9 edm output root files, 26 DQM output files

@@ -10,6 +10,7 @@

from FWCore.ParameterSet.Config import Process, EndPath
from FWCore.ParameterSet.Modules import OutputModule, Source, Service
from Configuration.EventContent.EventContent_cff import NANOAODEventContent
Copy link
Contributor

@slava77 slava77 Apr 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this has broken the event content for the production processing

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was noticed in #22933

Some different way to load EventContent_cff has to happen here
This file uses eras and it can only work properly after the cms.Process is created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants