Fc fix ecal al ca reco producer

[fabiocos]

Replace FileInPath with string in the configuration built at compilation time to avoid problems with the build system (see #21955)

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21958/3038

[cmsbuild]

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

Calibration/EcalAlCaRecoProducers

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @tocheng, @argiro this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25621/console Started: 2018/01/25 16:19

[Dr15Jones]

I'm not very happy with this change since it takes away the purpose of FileInPath. We want more use of FileInPath to help with configurations, not less of them.

[fabiocos]

@Dr15Jones this is the only case that I see in which FileInPath is used in a dynamic build of a configuration. I agree this is undoing the good of FileInPath, but unless we want to modify the build procedure is to avoid to create dynamically the configuration. Or do you suggest other solutions?

[cmsbuild]

+1
Tested at: 051ff42
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21958/25621/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21958/25621/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21958/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2468615
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2468445
• DQMHistoTests: Total skipped: 169
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.12999999999 KiB( 22 files compared)
• Checked 110 log files, 9 edm output root files, 26 DQM output files

[fabiocos]

No more needed after the fix of FilInPath in #21966