Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a configurable input for the caloTowerCollection #2196

Merged
merged 1 commit into from Jan 30, 2014

Conversation

perrotta
Copy link
Contributor

Allow a configurable input for the caloTowerCollection (previously hard-coded in the c++ file)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @perrotta for CMSSW_7_0_X.

Allow a configurable input for the caloTowerCollection

It involves the following packages:

HLTrigger/JetMET

@perrotta, @cmsbuild, @nclopezo, @Martin-Grunewald, @fwyzard, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@perrotta
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

-1
When I ran the RelVals I found an error in the following worklfows:
5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log
----- Begin Fatal Exception 28-Jan-2014 15:01:33 CET-----------------------
An exception of category 'PFRecoTauDiscriminationAgainstElectronMVA5GBR' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=PFRecoTauDiscriminationAgainstElectronMVA5GBR label='hpsPFTauDiscriminationByMVA5rawElectronRejection'
Exception Message:
 Failed to find File = V001 RecoTauTag/RecoTau/data/gbrDiscriminationAgainstElectronMVA5.root 2 /src/RecoTauTag/RecoTau/data/gbrDiscriminationAgainstElectronMVA5.root !!
----- End Fatal Exception -------------------------------------------------

401.0 step1

runTheMatrix-results/401.0_TTbarNewMix+TTbarFSPU2+HARVESTFS/step1_TTbarNewMix+TTbarFSPU2+HARVESTFS.log
----- Begin Fatal Exception 28-Jan-2014 15:01:39 CET-----------------------
An exception of category 'PFRecoTauDiscriminationAgainstElectronMVA5GBR' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=PFRecoTauDiscriminationAgainstElectronMVA5GBR label='hpsPFTauDiscriminationByMVA5rawElectronRejection'
Exception Message:
 Failed to find File = V001 RecoTauTag/RecoTau/data/gbrDiscriminationAgainstElectronMVA5.root 2 /src/RecoTauTag/RecoTau/data/gbrDiscriminationAgainstElectronMVA5.root !!
----- End Fatal Exception -------------------------------------------------

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD.log
----- Begin Fatal Exception 28-Jan-2014 15:01:48 CET-----------------------
An exception of category 'PFRecoTauDiscriminationAgainstElectronMVA5GBR' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=PFRecoTauDiscriminationAgainstElectronMVA5GBR label='hpsPFTauDiscriminationByMVA5rawElectronRejection'
Exception Message:
 Failed to find File = V001 RecoTauTag/RecoTau/data/gbrDiscriminationAgainstElectronMVA5.root 2 /src/RecoTauTag/RecoTau/data/gbrDiscriminationAgainstElectronMVA5.root !!
----- End Fatal Exception -------------------------------------------------

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log
----- Begin Fatal Exception 28-Jan-2014 15:01:52 CET-----------------------
An exception of category 'PFRecoTauDiscriminationAgainstElectronMVA5GBR' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=PFRecoTauDiscriminationAgainstElectronMVA5GBR label='hpsPFTauDiscriminationByMVA5rawElectronRejection'
Exception Message:
 Failed to find File = V001 RecoTauTag/RecoTau/data/gbrDiscriminationAgainstElectronMVA5.root 2 /src/RecoTauTag/RecoTau/data/gbrDiscriminationAgainstElectronMVA5.root !!
----- End Fatal Exception -------------------------------------------------

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log
----- Begin Fatal Exception 28-Jan-2014 15:01:56 CET-----------------------
An exception of category 'PFRecoTauDiscriminationAgainstElectronMVA5GBR' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=PFRecoTauDiscriminationAgainstElectronMVA5GBR label='hpsPFTauDiscriminationByMVA5rawElectronRejection'
Exception Message:
 Failed to find File = V001 RecoTauTag/RecoTau/data/gbrDiscriminationAgainstElectronMVA5.root 2 /src/RecoTauTag/RecoTau/data/gbrDiscriminationAgainstElectronMVA5.root !!
----- End Fatal Exception -------------------------------------------------

4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log
----- Begin Fatal Exception 28-Jan-2014 15:05:06 CET-----------------------
An exception of category 'PFRecoTauDiscriminationAgainstElectronMVA5GBR' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=PFRecoTauDiscriminationAgainstElectronMVA5GBR label='hpsPFTauDiscriminationByMVA5rawElectronRejection'
Exception Message:
 Failed to find File = V001 RecoTauTag/RecoTau/data/gbrDiscriminationAgainstElectronMVA5.root 2 /src/RecoTauTag/RecoTau/data/gbrDiscriminationAgainstElectronMVA5.root !!
----- End Fatal Exception -------------------------------------------------

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log
----- Begin Fatal Exception 28-Jan-2014 15:05:09 CET-----------------------
An exception of category 'PFRecoTauDiscriminationAgainstElectronMVA5GBR' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=PFRecoTauDiscriminationAgainstElectronMVA5GBR label='hpsPFTauDiscriminationByMVA5rawElectronRejection'
Exception Message:
 Failed to find File = V001 RecoTauTag/RecoTau/data/gbrDiscriminationAgainstElectronMVA5.root 2 /src/RecoTauTag/RecoTau/data/gbrDiscriminationAgainstElectronMVA5.root !!
----- End Fatal Exception -------------------------------------------------

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT.log
----- Begin Fatal Exception 28-Jan-2014 15:12:14 CET-----------------------
An exception of category 'PFRecoTauDiscriminationAgainstElectronMVA5GBR' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=PFRecoTauDiscriminationAgainstElectronMVA5GBR label='hpsPFTauDiscriminationByMVA5rawElectronRejection'
Exception Message:
 Failed to find File = V001 RecoTauTag/RecoTau/data/gbrDiscriminationAgainstElectronMVA5.root 2 /src/RecoTauTag/RecoTau/data/gbrDiscriminationAgainstElectronMVA5.root !!
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2196/5/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (but tests are reportedly failing). @ktf can you please take care of it?

@fwyzard
Copy link
Contributor

fwyzard commented Jan 28, 2014

OK, the errors look definitely unrelated...

@Martin-Grunewald
Copy link
Contributor

This error IS complete unrelated and fixed by PR #2193 #2193

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (tests are also fine). @ktf can you please take care of it?

@davidlange6
Copy link
Contributor

+1

ktf added a commit that referenced this pull request Jan 30, 2014
HLT -- Allow a configurable input for the caloTowerCollection
@ktf ktf merged commit 2a25586 into cms-sw:CMSSW_7_0_X Jan 30, 2014
@perrotta perrotta deleted the fixHLTExclDiJetFilter branch February 1, 2014 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants