Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting a Spy Config #21973

Merged
merged 2 commits into from Feb 6, 2018
Merged

Splitting a Spy Config #21973

merged 2 commits into from Feb 6, 2018

Conversation

Jangbae
Copy link
Contributor

@Jangbae Jangbae commented Jan 26, 2018

Hi,

This pull request is for mainly updating the spy display and spy event matching configs. The spy display and event matching configs are split into two for different mainstream data, Virgin raw and Zero suppressed. 'VR'('ZS') tagged configs are to be used once the spy data are compared to Virgin raw(Zero Suppressed) mainstream data.

Regards,
Jangbae

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Jangbae for master.

It involves the following packages:

DQM/SiStripMonitorHardware

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @fioriNTU, @hdelanno this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

@Jangbae please introduce yourself, we have not identifed you as DQM Contact on
https://twiki.cern.ch/twiki/bin/viewauth/CMS/DQMContacts
Thanks

@boudoul
Copy link
Contributor

boudoul commented Jan 26, 2018

hi @jfernan2 , I believe that @Jangbae already introduced himself )through 'cms-dqm-coreTeam@cern.ch' on Dec 14 (as already requested at his last PR)

@fioriNTU
Copy link
Contributor

@boudoul and @jfernan2 , just to clarify, @Jangbae is not a DQM developer, he is a Strip local reco developer. He is pushing PR in the DQM because, by chance, the package he is editing is among the TkDQM packages. I think this will change in the near future.

@jfernan2
Copy link
Contributor

please test
Thanks @boudoul @fioriNTU I did not recall his introduction, and since he was not identified in the twiki, I made the usual security question (anybody in GitHub could make a PR for any CMSSW package)
Even if he is not a DQM developer, I would be good to have him settled somewhere for future references.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 26, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25651/console Started: 2018/01/26 20:06

@@ -0,0 +1,11939 @@
%MSG-i Geometry: (NoModuleName) CSCGeometryESModule() 26-Jan-2018 15:07:28 CET pre-events
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Jangbae is there any reason why this and other largish log files are included in this PR? It looks like a leftover of some test to me. Cheers and thanks.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

1 similar comment
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2018

Pull request #21973 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please check and sign again.

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25922/console Started: 2018/02/06 15:53

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21973/25922/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21973/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2465763
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2465593
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.99000000002 KiB( 22 files compared)
  • Checked 110 log files, 9 edm output root files, 26 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Feb 6, 2018

+1

@cmsbuild cmsbuild merged commit 1a261c4 into cms-sw:master Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants