Fix collapsed status in HCAL topology [100X]

[kpedro88]

Backport of #22001

[cmsbuild]

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_10_0_X.

It involves the following packages:

Configuration/PyReleaseValidation
DQMOffline/Hcal
Geometry/CaloTopology
Geometry/HcalEventSetup
Geometry/HcalTowerAlgo
HLTrigger/Configuration
RecoLocalCalo/CaloTowersCreator
RecoLocalCalo/HcalRecAlgos
RecoLocalCalo/HcalRecProducers
RecoParticleFlow/PFClusterProducer

@perrotta, @cmsbuild, @prebello, @Dr15Jones, @vazzolini, @kmaeshima, @civanch, @fwyzard, @ianna, @kpedro88, @fabozzi, @Martin-Grunewald, @silviodonato, @jfernan2, @mdhildreth, @slava77, @GurpreetSinghChahal, @vanbesien, @dmitrijus can you please review it and eventually sign? Thanks.
@ghellwig, @mmarionncern, @makortel, @felicepantaleo, @rovere, @lgray, @Martin-Grunewald, @ebrondol, @seemasharmafnal, @jalimena, @cbernet, @mariadalfonso, @argiro, @geoff-smith, @bachtis, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Fix collapsed status in HCAL topology #22001

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25701/console Started: 2018/01/28 16:39

[cmsbuild]

+1
Tested at: 8d272d1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22002/25701/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22002/25701/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22002/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

• You potentially added 30155 lines to the logs
• Reco comparison results: 1486 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2467599
• DQMHistoTests: Total failures: 5534
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2461896
• DQMHistoTests: Total skipped: 169
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.710000000072 KiB( 22 files compared)
• Checked 110 log files, 9 edm output root files, 26 DQM output files

[prebello]

+1

[kpedro88]

+1

[prebello]

+1

[Martin-Grunewald]

+1

[jfernan2]

+1

[perrotta]

+1

• Just in case the backport to 10_0_1 is needed, this is identical to Fix collapsed status in HCAL topology #22001

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[deguio]

Hi @fabiocos
I was hoping to have this one considered for 10_0_1
what's the plan for integrating it? it would be good to have it in the release which is going to be used for the MC prod.

@abdoulline @mariadalfonso @hatakeyamak

[fabiocos]

@deguio 10_0_1 was built to quickly start GEN-SIM, this PR is not affecting GEN-SIM as far as I can see, am I correct? For next steps we will need to collect whatever is needed, at the end of the validation

[deguio]

ok, sounds good then. :)
thanks,
F.

[fabiocos]

+1