New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TrackingTools/PatternTools: ESProducers updated to return unique_ptr. #22017
TrackingTools/PatternTools: ESProducers updated to return unique_ptr. #22017
Conversation
Use std::move to pass pointer ownership from constructed ptr type to return ptr type.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22017/3112 |
A new Pull Request was created by @gartung (Patrick Gartung) for master. It involves the following packages: TrackingTools/PatternTools @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
||
|
||
return pTSCBLBuilderNoMaterial ; | ||
return std::move(pTSCBLBuilderNoMaterial) ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The std::move
before the return is not needed (and actually can turn off a compiler optimization).
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22017/3113 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Use std::move to pass pointer ownership from constructed ptr type to return ptr type.