Hcal validation update 10_0_X ieta shift fix v2

[bcmcms]

Updates include:

(1) fix a few plots in which ieta was shifted

(2) fix error bars for some plots

(3) clean up some obsolete files

(4) fix era setting for digi validation plots

(5) make the digi time sample analysis less hard-coded (uses soi from tool.presamples() everywhere)

(6) For some of energy mean vs ieta plots, we moved from “s” (RMS spread error) to ” ” (error on the mean)

(7) use a separate ME for HO’s “emap”, as HO being plotted at depth=7 caused confusions (plotting at depth=4 can collide with HB depth=4 after HB phase1 upgrade)

This is a cleaner copy of #21856 which had to be closed.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22034/3134

[cmsbuild]

A new Pull Request was created by @bcmcms for master.

It involves the following packages:

DQMOffline/Hcal
Validation/CaloTowers
Validation/HcalDigis
Validation/HcalHits
Validation/HcalRecHits

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[bcmcms]

@deguio, @salavat, @hatakeyamak, @fabiocos this is relevant to you as well.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22034/3153

[cmsbuild]

Pull request #22034 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please check and sign again.

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25788/console Started: 2018/01/31 09:20

[cmsbuild]

+1
Tested at: d8e9df5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22034/25788/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22034/25788/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22034/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2463035
• DQMHistoTests: Total failures: 916
• DQMHistoTests: Total nulls: 188
• DQMHistoTests: Total successes: 2461762
• DQMHistoTests: Total skipped: 169
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1407.98 KiB( 22 files compared)
• Checked 110 log files, 9 edm output root files, 26 DQM output files

[dmitrijus]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1