NanoAOD Update: trigger, nPV, pileup (10_0_X)

[arizzi]

This includes:

• tune of trigger objects
• fix of trigger bits when version number changes
• n goodPV
• oot pileup

All changes are in PhysicsTools/NanoAOD

backport of #22037

@gpetruc

[cmsbuild]

A new Pull Request was created by @arizzi for CMSSW_10_0_X.

It involves the following packages:

PhysicsTools/NanoAOD

@cmsbuild, @monttj can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[gpetruc]

why this didn't trigger code checks?

[davidlange6]

its not a PR for the development branch

…

On Jan 30, 2018, at 10:16 AM, Giovanni Petrucciani ***@***.***> wrote: why this didn't trigger code checks? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[cmsbuild]

Pull request #22038 was updated. @cmsbuild, @monttj can you please check and sign again.

[arizzi]

this needs #21944 (already merged in 94X and 10_1_X)

[fabiocos]

+1

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25856/console Started: 2018/02/01 22:50

[fabiocos]

merge

[cmsbuild]

-1

Tested at: 785f7e3

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22038/25856/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests RelVals

• Unit Tests:

I found errors in the following unit tests:

---> test runtestPhysicsToolsNanoAOD had ERRORS

• RelVals:

When I ran the RelVals I found an error in the following worklfows:
1325.7 step2

runTheMatrix-results/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017/step2_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017.log

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[fabiocos]

apparently the test was not including already #21944 . Anyway the IB including this PR was successful.