Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedicated Timing Plots - New Settings for uGT and Eta/Phi Map - L1T & Online DQM - CMSSW - 100X #22052

Merged
merged 7 commits into from Feb 13, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jan 31, 2018

My task in JIRA is : ([https://its.cern.ch/jira/browse/CMSLITDPG-165]).

First of all, I would like to mention that I added a new and more convenient way to implement the necessary algorithm trigger bits (L1_FirstCollisionInTrain, L1_LastCollisionInTrain) for producing pre- post- firing plots using them as parameters for the first bunch, last bunch and isolated bunch. After that, I produced a new module for producing pre- post- firing plots with a second way using eta/phi map for L1T objects (muon, jet, tau, egamma, MET) for every BX as well as for the first bunch, last bunch and isolated bunch.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 31, 2018

A new Pull Request was created by @dtsitson for CMSSW_10_0_X.

It involves the following packages:

DQM/L1TMonitor

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@kreczko, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@ghost
Copy link
Author

ghost commented Jan 31, 2018

backport of #21793

@thomreis
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 31, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25801/console Started: 2018/01/31 15:57

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22052/25801/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22052/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2468773
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2468600
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1566.86 KiB( 22 files compared)
  • Checked 110 log files, 9 edm output root files, 26 DQM output files

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2018

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f0ab215 into cms-sw:CMSSW_10_0_X Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants