Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for most of the tags in the 10.0.x 2018 global tags. #22055

Merged
merged 1 commit into from Feb 6, 2018

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jan 31, 2018

Add support for all the tags included in the global tags

  • 100X_upgrade2018_realistic
  • 100X_dataRun2_HLT

except for few tags, that give problems while building or testing

  • HBHENegativeEFilter
  • HcalItemCollById<HFPhase1PMTData>
  • PhysicsTools::Calibration::Histogram3D<double, double, double, double>
  • StorableDoubleMap<AbsOOTPileupCorrection>

Add support for all the tags included in the global tags
  - 100X_upgrade2018_realistic
  - 100X_dataRun2_HLT

except for few tags, that give problems while building or testing
  - HBHENegativeEFilter
  - HcalItemCollById<HFPhase1PMTData>
  - PhysicsTools::Calibration::Histogram3D<double, double, double, double>
  - StorableDoubleMap<AbsOOTPileupCorrection>
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 31, 2018

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_10_0_X.

It involves the following packages:

CondCore/Utilities

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 31, 2018

backport #22054

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 31, 2018

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 31, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25805/console Started: 2018/01/31 16:10

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22055/25805/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22055/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2468773
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2468603
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.45000000004 KiB( 22 files compared)
  • Checked 110 log files, 9 edm output root files, 26 DQM output files

@ggovi
Copy link
Contributor

ggovi commented Feb 2, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2018

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Feb 6, 2018

+1

@cmsbuild cmsbuild merged commit 25d29f4 into cms-sw:CMSSW_10_0_X Feb 6, 2018
@fwyzard fwyzard deleted the extend_conddb_dump_100x branch February 16, 2018 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants