Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BMTF ZS Unpacker #22059

Merged
merged 9 commits into from Feb 20, 2018
Merged

Conversation

panoskatsoulis
Copy link
Contributor

This is the new BMTF Unpacker to support the Zero Suppression firmware feature.
It is tested with about 40M events (unsuppressed format) and it seems to work.

The main purpose of the pull request is to make it able for the forthcoming MWGR#2 for further testing with DQM,and also for validation purposes after the Global Run.

Very probable an updated version will be proposed too.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 31, 2018

A new Pull Request was created by @panoskatsoulis for CMSSW_10_0_X.

It involves the following packages:

EventFilter/L1TRawToDigi

@nsmith-, @cmsbuild, @thomreis, @rekovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@thomreis
Copy link
Contributor

please test

@thomreis
Copy link
Contributor

backport of #22058

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 31, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25810/console Started: 2018/01/31 17:36

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22059/25810/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22059/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2468773
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2468603
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.44999999994 KiB( 22 files compared)
  • Checked 110 log files, 9 edm output root files, 26 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2018

Pull request #22059 was updated. @nsmith-, @cmsbuild, @thomreis, @rekovic can you please check and sign again.

@thomreis
Copy link
Contributor

thomreis commented Feb 1, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 1, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25836/console Started: 2018/02/01 13:15

@cmsbuild
Copy link
Contributor

Pull request #22059 was updated. @nsmith-, @cmsbuild, @thomreis, @rekovic can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #22059 was updated. @nsmith-, @cmsbuild, @thomreis, @rekovic can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #22059 was updated. @nsmith-, @cmsbuild, @thomreis, @rekovic can you please check and sign again.

@thomreis
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 15, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26113/console Started: 2018/02/15 22:48

@thomreis
Copy link
Contributor

unhold

@cmsbuild cmsbuild removed the hold label Feb 15, 2018
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22059/26113/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2469361
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2469191
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.859999999979 KiB( 22 files compared)
  • Checked 111 log files, 9 edm output root files, 27 DQM output files

@thomreis
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 058ed9f into cms-sw:CMSSW_10_0_X Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants