CalibTracker/SiStripESProducers: ESProducers update to return unique_ptr. #22062

gartung · 2018-01-31T19:17:45Z

No description provided.

…ptr.

cmsbuild · 2018-01-31T19:18:05Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-01-31T19:19:37Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22062/3182

cmsbuild · 2018-01-31T19:19:54Z

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

CalibTracker/SiStripESProducers

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @jlagram, @mmusich, @gbenelli, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

ghellwig · 2018-02-01T08:13:50Z

please test

cmsbuild · 2018-02-01T08:14:06Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25831/console Started: 2018/02/01 09:16

ghellwig · 2018-02-01T08:14:38Z

CalibTracker/SiStripESProducers/plugins/fake/SiStripApvGainFakeESSource.cc

@@ -71,7 +71,7 @@ SiStripApvGainFakeESSource::produce(const SiStripApvGainRcd& iRecord)
 {
  using namespace edm::es;

-  std::shared_ptr<SiStripApvGain> apvGain{new SiStripApvGain};
+  std::unique_ptr<SiStripApvGain> apvGain{new SiStripApvGain};


please change to

auto apvGain = std::make_unique<SiStripApvGain>();

ghellwig · 2018-02-01T08:15:10Z

CalibTracker/SiStripESProducers/plugins/fake/SiStripBackPlaneCorrectionFakeESSource.cc

@@ -67,7 +67,7 @@ SiStripBackPlaneCorrectioNFakeESSource::produce(const SiStripBackPlaneCorrection
  edm::ESHandle<TrackerTopology> tTopo;
  iRecord.getRecord<TrackerTopologyRcd>().get(tTopo);

-  std::shared_ptr<SiStripBackPlaneCorrection> backPlaneCorrection{new SiStripBackPlaneCorrection};
+  std::unique_ptr<SiStripBackPlaneCorrection> backPlaneCorrection = std::make_unique<SiStripBackPlaneCorrection>();


please use auto

ghellwig · 2018-02-01T08:15:22Z

CalibTracker/SiStripESProducers/plugins/fake/SiStripBadModuleConfigurableFakeESSource.cc

@@ -73,7 +73,7 @@ SiStripBadModuleConfigurableFakeESSource::produce(const SiStripBadModuleRcd& iRe
  edm::ESHandle<TrackerTopology> tTopo;
  iRecord.getRecord<TrackerTopologyRcd>().get(tTopo);

-  std::shared_ptr<SiStripQuality> quality{new SiStripQuality};
+  std::unique_ptr<SiStripQuality> quality = std::make_unique<SiStripQuality>();


please use auto

ghellwig · 2018-02-01T08:15:32Z

CalibTracker/SiStripESProducers/plugins/fake/SiStripBaseDelayFakeESSource.cc

@@ -64,7 +64,7 @@ SiStripBaseDelayFakeESSource::produce(const SiStripBaseDelayRcd& iRecord)
 {
  using namespace edm::es;

-  std::shared_ptr<SiStripBaseDelay> baseDelay{new SiStripBaseDelay};
+  std::unique_ptr<SiStripBaseDelay> baseDelay = std::make_unique<SiStripBaseDelay>();


please use auto

ghellwig · 2018-02-01T08:15:47Z

CalibTracker/SiStripESProducers/plugins/fake/SiStripConfObjectFakeESSource.cc

@@ -61,7 +61,7 @@ SiStripConfObjectFakeESSource::produce(const SiStripConfObjectRcd& iRecord)
 {
  using namespace edm::es;

-  std::shared_ptr<SiStripConfObject> confObject{new SiStripConfObject};
+  std::unique_ptr<SiStripConfObject> confObject = std::make_unique<SiStripConfObject>();


please use auto

ghellwig · 2018-02-01T08:15:54Z

CalibTracker/SiStripESProducers/plugins/fake/SiStripLatencyFakeESSource.cc

@@ -64,7 +64,7 @@ SiStripLatencyFakeESSource::produce(const SiStripLatencyRcd& iRecord)
 {
  using namespace edm::es;

-  std::shared_ptr<SiStripLatency> latency{new SiStripLatency};
+  std::unique_ptr<SiStripLatency> latency = std::make_unique<SiStripLatency>();


please use auto

ghellwig · 2018-02-01T08:16:00Z

CalibTracker/SiStripESProducers/plugins/fake/SiStripLorentzAngleFakeESSource.cc

@@ -169,7 +169,7 @@ SiStripLorentzAngleFakeESSource::produce(const SiStripLorentzAngleRcd& iRecord)
  edm::ESHandle<TrackerTopology> tTopo;
  iRecord.getRecord<TrackerTopologyRcd>().get(tTopo);

-  std::shared_ptr<SiStripLorentzAngle> lorentzAngle{new SiStripLorentzAngle};
+  std::unique_ptr<SiStripLorentzAngle> lorentzAngle = std::make_unique<SiStripLorentzAngle>();


please use auto

ghellwig · 2018-02-01T08:16:06Z

CalibTracker/SiStripESProducers/plugins/fake/SiStripNoisesFakeESSource.cc

@@ -98,7 +98,7 @@ SiStripNoisesFakeESSource::produce(const SiStripNoisesRcd& iRecord)
  edm::ESHandle<TrackerTopology> tTopo;
  iRecord.getRecord<TrackerTopologyRcd>().get(tTopo);

-  std::shared_ptr<SiStripNoises> noises{new SiStripNoises};
+  std::unique_ptr<SiStripNoises> noises = std::make_unique<SiStripNoises>();


please use auto

ghellwig · 2018-02-01T08:16:12Z

CalibTracker/SiStripESProducers/plugins/fake/SiStripPedestalsFakeESSource.cc

@@ -64,7 +64,7 @@ SiStripPedestalsFakeESSource::produce(const SiStripPedestalsRcd& iRecord)
 {
  using namespace edm::es;

-  std::shared_ptr<SiStripPedestals> pedestals{new SiStripPedestals};
+  std::unique_ptr<SiStripPedestals> pedestals = std::make_unique<SiStripPedestals>();


please use auto

ghellwig · 2018-02-01T08:16:34Z

CalibTracker/SiStripESProducers/plugins/real/SiStripBadModuleFedErrESSource.cc

@@ -125,7 +125,7 @@ SiStripBadModuleFedErrESSource::produce(const SiStripBadModuleFedErrRcd& iRecord
  edm::ESHandle<SiStripFedCabling> cabling;
  iRecord.getRecord<SiStripFedCablingRcd>().get(cabling);

-  std::shared_ptr<SiStripQuality> quality{new SiStripQuality};
+  std::unique_ptr<SiStripQuality> quality = std::make_unique<SiStripQuality>();


please use auto

cmsbuild · 2018-02-01T09:48:12Z

+1
Tested at: 007d2a7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22062/25831/summary.html

cmsbuild · 2018-02-01T09:48:14Z

Comparison job queued.

cmsbuild · 2018-02-01T10:26:52Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22062/25831/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22062/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 26
DQMHistoTests: Total histograms compared: 2465763
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2465593
DQMHistoTests: Total skipped: 169
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 1.13999999982 KiB( 22 files compared)
Checked 110 log files, 9 edm output root files, 26 DQM output files

cmsbuild · 2018-02-01T16:04:41Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-02-01T16:07:06Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22062/3199

cmsbuild · 2018-02-01T16:07:27Z

Pull request #22062 was updated. @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please check and sign again.

ghellwig · 2018-02-02T13:16:17Z

please test

cmsbuild · 2018-02-02T13:17:00Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25868/console Started: 2018/02/02 14:17

ghellwig · 2018-02-02T13:17:01Z

+1

cmsbuild · 2018-02-02T13:17:20Z

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2018-02-02T15:00:06Z

+1
Tested at: 146417c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22062/25868/summary.html

cmsbuild · 2018-02-02T15:00:12Z

Comparison job queued.

cmsbuild · 2018-02-02T16:20:41Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22062/25868/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22062/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 26
DQMHistoTests: Total histograms compared: 2465763
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2465593
DQMHistoTests: Total skipped: 169
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 1.11000000006 KiB( 22 files compared)
Checked 110 log files, 9 edm output root files, 26 DQM output files

fabiocos · 2018-02-03T19:07:15Z

+1

CalibTracker/SiStripESProducers: ESProducers update to return unique_…

007d2a7

…ptr.

cmsbuild added this to the CMSSW_10_1_X milestone Jan 31, 2018

cmsbuild added alca-pending code-checks-pending comparison-pending orp-pending pending-signatures tests-pending labels Jan 31, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 31, 2018

cmsbuild added tests-started and removed tests-pending labels Feb 1, 2018

ghellwig reviewed Feb 1, 2018

View reviewed changes

cmsbuild added tests-approved and removed tests-started labels Feb 1, 2018

cmsbuild added comparison-available and removed comparison-pending labels Feb 1, 2018

use auto

04c8720

cmsbuild added code-checks-pending and removed code-checks-approved comparison-available tests-approved labels Feb 1, 2018

missed one

146417c

cmsbuild added code-checks-pending and removed code-checks-approved labels Feb 1, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 1, 2018

cmsbuild added alca-approved fully-signed tests-started and removed alca-pending pending-signatures tests-pending labels Feb 2, 2018

cmsbuild added tests-approved and removed tests-started labels Feb 2, 2018

cmsbuild added comparison-available and removed comparison-pending labels Feb 2, 2018

cmsbuild added orp-approved and removed orp-pending labels Feb 3, 2018

cmsbuild merged commit c57b629 into cms-sw:master Feb 3, 2018

gartung deleted the CalibTracker-SiStripESProducers-ESProducers-returntype branch February 7, 2018 01:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CalibTracker/SiStripESProducers: ESProducers update to return unique_ptr. #22062

CalibTracker/SiStripESProducers: ESProducers update to return unique_ptr. #22062

gartung commented Jan 31, 2018

cmsbuild commented Jan 31, 2018

cmsbuild commented Jan 31, 2018

cmsbuild commented Jan 31, 2018

ghellwig commented Feb 1, 2018

cmsbuild commented Feb 1, 2018 •

edited

ghellwig Feb 1, 2018

ghellwig Feb 1, 2018

ghellwig Feb 1, 2018

ghellwig Feb 1, 2018

ghellwig Feb 1, 2018

ghellwig Feb 1, 2018

ghellwig Feb 1, 2018

ghellwig Feb 1, 2018

ghellwig Feb 1, 2018

ghellwig Feb 1, 2018

cmsbuild commented Feb 1, 2018

cmsbuild commented Feb 1, 2018

cmsbuild commented Feb 1, 2018

cmsbuild commented Feb 1, 2018

cmsbuild commented Feb 1, 2018

cmsbuild commented Feb 1, 2018

ghellwig commented Feb 2, 2018

cmsbuild commented Feb 2, 2018 •

edited

ghellwig commented Feb 2, 2018

cmsbuild commented Feb 2, 2018

cmsbuild commented Feb 2, 2018

cmsbuild commented Feb 2, 2018

cmsbuild commented Feb 2, 2018

fabiocos commented Feb 3, 2018

CalibTracker/SiStripESProducers: ESProducers update to return unique_ptr. #22062

CalibTracker/SiStripESProducers: ESProducers update to return unique_ptr. #22062

Conversation

gartung commented Jan 31, 2018

cmsbuild commented Jan 31, 2018

cmsbuild commented Jan 31, 2018

cmsbuild commented Jan 31, 2018

ghellwig commented Feb 1, 2018

cmsbuild commented Feb 1, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cmsbuild commented Feb 1, 2018

cmsbuild commented Feb 1, 2018

cmsbuild commented Feb 1, 2018

cmsbuild commented Feb 1, 2018

cmsbuild commented Feb 1, 2018

cmsbuild commented Feb 1, 2018

ghellwig commented Feb 2, 2018

cmsbuild commented Feb 2, 2018 • edited

ghellwig commented Feb 2, 2018

cmsbuild commented Feb 2, 2018

cmsbuild commented Feb 2, 2018

cmsbuild commented Feb 2, 2018

cmsbuild commented Feb 2, 2018

fabiocos commented Feb 3, 2018

cmsbuild commented Feb 1, 2018 •

edited

cmsbuild commented Feb 2, 2018 •

edited