Protect ZdcSimpleRecAlgo buffer overflow issue #21250

[BetterWang]

Fix the heap buffer overflow issue:
#21250

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22063/3183

[cmsbuild]

A new Pull Request was created by @BetterWang (Quan Wang) for master.

It involves the following packages:

RecoLocalCalo/HcalRecAlgos

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@mariadalfonso, @argiro this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25817/console Started: 2018/01/31 22:57

[perrotta]

@BetterWang : could you please edit the title of this PR so that it is more evident where the buffer overflow was? (e.g., add "in ZdcSimpleRecAlgo")

[cmsbuild]

+1
Tested at: 6d7bc4a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22063/25817/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
1a454c2
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22063/25817/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22063/25817/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22063/25817/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22063/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2465763
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2465593
• DQMHistoTests: Total skipped: 169
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.880000000136 KiB( 22 files compared)
• Checked 110 log files, 9 edm output root files, 26 DQM output files

[slava77]

@davidlt
please clarify how to check that this fixes the problem reported in the ASAN build

[slava77]

+1

for #22063 6d7bc4a

• fixes the buffer overflow in run1 data processing in the ZdcHitReconstructor
• jenkins tests pass and comparisons show no differences
• local tests in CMSSW_10_0_ASAN_X_2018-01-21-0000 show that the crash is present in 1002.0 in the baseline and it goes away with this PR changes.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1